Repository navigation
Make published plugin bundles reproducible - #54
Merged
Merged
Conversation
Bundles carried esbuild path comments with the builder's temporary directory, so no two builds matched. Minify the output, and read the plugin definition from a bundle of its module so a plugin kept in another repository needs no install of this package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #53. Two problems with
scripts/bundle-plugin.ts:@sidequery/artifacts/plugins, and in a directory withoutnode_modulesBun auto-installed the old npm release instead. The definition is now read from an esbuild bundle of the module, using the same alias as the shipped bundle.A new test builds the fixture from another directory and expects identical bytes and no machine paths. The Miniflare runtime-plugin tests (6/0), the celld runtime-plugin test, and typecheck pass.