Repository navigation
Add semantic SQL discovery and definition lifecycle - #406
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 826cf1dc41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| let incoming = Snapshot::from_graph(&incoming.into_graph()?); | ||
| let mut merged = Snapshot::parse(snapshot)?; | ||
| merged.merge(incoming); |
There was a problem hiding this comment.
When the destination contains orders and the imported snapshot defines ORDERS, this merge does not replace the existing model as documented: Snapshot::merge removes entries using exact string equality, while DuckDB semantic identifiers are treated case-insensitively elsewhere in this change. Both declarations therefore remain in the reconstructed graph, leading to duplicate discovery rows and ambiguous or casing-dependent query resolution. Match model and other catalog identifier names with eq_ignore_ascii_case during import.
Useful? React with 👍 / 👎.
1 participant
Add ordinary semantic SELECT routing across DuckDB 1.5.6 and the pinned 2.x frontend, including autocomplete, prepared queries, bound filters, and SQL containers.
Add SHOW/DESCRIBE discovery from the transactional catalog, compiler-checked compatible dimensions, model-qualified creation and replacement, dependency-restricted removal, and versioned catalog export/import. Definition operations preserve transaction, read-only, and prepare/describe behavior.
Add native and host regressions, including an authenticated DuckFlight PostgreSQL client suite. Full prepared-client compatibility also uses the sidequery/duckflight#229 and sidequery/duckdb-rs#6.