Repository navigation
Fix Rust parity gaps and add differential evidence - #409
Merged
Merged
Conversation
nicosuave
marked this pull request as ready for review
October 7, 2026 00:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fanout, default-time, population ownership/policy, and window alias mismatches between the Python and Rust engines. Exact dotted graph identities now retain their ownership and visibility checks; native cumulative identifiers are quoted; Python evaluates source-local formulas after missing-source counts/defaults are restored. Unsupported Redshift approximate distinct windows fail explicitly.
Adds expected-result regressions, minimized replay cases, a seeded DuckDB differential runner, and an auditable inventory of shared-suite exclusions and helper coverage. Raises the DuckDB minimum to 1.4.4 for cumulative NULL-date correctness and makes date-bucket expectations compatible with DuckDB 1.5. Fixes Snowflake emulator dependency resolution and date-only browser filter bounds in non-UTC timezones.
Python remains the default. The inventory still contains 54
real-gaprecords, including unproven native coverage; these are not 54 confirmed product defects. A default switch remains separate work.Validation on Python 3.13 / DuckDB 1.5.6 with a rebuilt native engine:
Follow-up verification: all main CI and integration checks passed on
1d75fa6f; the only remaining failure was live Yardstick fixture timestamp formatting.35acb68drepairs that adapter and adds regressions without relaxing time-value checks. The complete live and vendored replay module passed 27 tests against Yardstick0b5fc827321b71b7bb6379d9259fe8b2ea243a79. Final-head CI is pending.