fix(theme): update tab visual design - #2529
Merged
Merged
Conversation
spike-rabbit
force-pushed
the
fix/theme-tabs-design
branch
from
August 7, 2026 10:03
7c5e6e5 to
56ef56f
Compare
panch1739
reviewed
Aug 7, 2026
panch1739
left a comment
panch1739
left a comment
Member
There was a problem hiding this comment.
@spike-rabbit something is a bit odd, the font for the selected tab is changing to real bold (weight 700) instead of sbold (weight 600)...selected tab should use the style body-lg-bold
spike-rabbit
force-pushed
the
fix/theme-tabs-design
branch
2 times, most recently
from
August 7, 2026 17:25
fd7ac86 to
67e7a0e
Compare
spike-rabbit
marked this pull request as ready for review
August 10, 2026 11:28
hbxes
reviewed
Aug 11, 2026
hbxes
left a comment
hbxes
left a comment
Member
There was a problem hiding this comment.
Hey Maxi, good job, just 2 comments, where I'm unsure
hbxes
approved these changes
Aug 12, 2026
spike-rabbit
force-pushed
the
fix/theme-tabs-design
branch
from
August 14, 2026 14:14
67e7a0e to
bb802c2
Compare
chintankavathia
requested changes
Aug 17, 2026
chintankavathia
left a comment
chintankavathia
left a comment
Member
There was a problem hiding this comment.
- border below 3 dots is now mis aligned to tabs bottom border
- as per figma icon only tab should be 40x40 but currently its 48x40
Align tab underlines and typography with the updated visual design. Closes #2489
spike-rabbit
force-pushed
the
fix/theme-tabs-design
branch
from
August 17, 2026 12:16
bb802c2 to
f3127a4
Compare
Member
Author
|
fixed the border of menu button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align tab underlines and typography with the updated visual design.
Closes #2489
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: