rust(feat): docs search MCP tool#640
Open
evan-sift wants to merge 2 commits into
Open
Conversation
evan-sift
commented
Jun 24, 2026
Comment on lines
+16
to
+19
| credentials: Credentials, | ||
| use_tls: bool, | ||
| rest_uri: String, | ||
| api_key: String, |
Collaborator
Author
There was a problem hiding this comment.
is it incorrect here to have both credentials & API key?
Collaborator
There was a problem hiding this comment.
Yeah everything should be inside of Credentials and then baked into the grpc channel
evan-sift
commented
Jun 24, 2026
solidiquis
requested changes
Jun 25, 2026
Comment on lines
+16
to
+19
| credentials: Credentials, | ||
| use_tls: bool, | ||
| rest_uri: String, | ||
| api_key: String, |
Collaborator
There was a problem hiding this comment.
Yeah everything should be inside of Credentials and then baked into the grpc channel
| /// supplied JSON bodies, capturing the inbound query params and auth header for | ||
| /// assertion. Returns the service pointed at it plus the captured request state. | ||
| async fn service_with_routes( | ||
| search_body: &'static str, |
Collaborator
There was a problem hiding this comment.
Can you make these &str vs. &'static str
| /// (the same payload `read_doc` returns for that path) so a hit can be read | ||
| /// without a second request. Field names tolerate both the camelCase (protojson | ||
| /// default) and snake_case forms the gateway may emit; the struct serializes | ||
| /// back out in snake_case to match `read_doc`'s output. |
Contributor
There was a problem hiding this comment.
ReadDocResponse is camelCase so read_doc is returning a camelCase response
Do not think this is blocking, but maybe worth changing the wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for the docs search / docs read endpoints, behind an API token