rust(feat): return url after import#656
Open
Brandon-Shippy wants to merge 13 commits into
Open
Conversation
wei-qlu
reviewed
Jun 25, 2026
wei-qlu
reviewed
Jun 25, 2026
…ume from api url otherwise give no link
0246214 to
00e1851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to build deep explore urls directly linking to the asset/run that the user just imported.
Adds a section in the CLI config for users to input their web-uri to properly resolve links back to sift. Adds extra flow to config creation to handle optional
web_uri. If users omitweb_urithe CLI will not produce links and the agent will also surface no link to the user. Also adds a helper to help with url building, and percent encoding.If a URL is provided in the config, that overrides and we use that. If not, we check their api and see if they are on prod or gov, if so we resolve the link to be on prod or gov. If not, we check and see if they are on local and if so we resolve it to local. Otherwise, we just provide no link and surface to the user why.
Note: If a
--run-idis provided we will build the link using that. We follow the same idiomatic system that the CLI already follow:--run-idtakes precedence over--runBundled with this PR is also:
explore_urlparam towait for completionso that it can resolve the link on both--waitimports and non--waitimportsValidation