Repository navigation
Conversation
Address CVE-2026-104851 (fixed in fsspec 2026.6.0) in the util-genai and util-genai-evals-deepeval test requirements.
etserend
marked this pull request as ready for review
October 21, 2026 15:02
etserend
commented
Oct 21, 2026
etserend
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-5-5). It may contain mistakes.
Verdict: approve — Both FOSSA-flagged pins now point at fsspec 2026.9.0, above the 2026.6.0 fix, and both changelogs record the bump.
Follow-ups
Suggested follow-up work that could be tracked as Jira tickets:
util/opentelemetry-util-genai/pyproject.toml:41-41: Thefsspecextra still allowsfsspec>=2025.9.0, so end users can install a version affected by CVE-2026-104851. The same floor appears inutil/opentelemetry-util-genai-evals-deepeval/pyproject.toml:39andutil/opentelemetry-util-genai-emitters-splunk/pyproject.toml:39. Consider raising all three floors to>=2026.6.0. Do this together with the Python 3.9 support decision, because recent fsspec releases need Python >=3.10.instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/requirements.oldest.txt:74-74: These pins still use the vulnerablefsspec==2025.9.0, and FOSSA may flag them later:instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/requirements.oldest.txt:74instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/requirements.latest.txt:78instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/requirements.oldest.txt:30
The example pin fsspec==2025.10.0 in requirements.traceloop.txt:34 is also below 2026.6.0. Consider bumping the latest and example pins now. Review the oldest pins separately.
util/opentelemetry-util-genai/CHANGELOG.md:5-10: This is an old problem, not part of this change. TheVersion 0.1.15section sits above## [Unreleased], so the file is out of order. The deepeval changelog lists[Unreleased]first. Consider movingVersion 0.1.15below[Unreleased]so both files follow the same layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CVE-2026-104851 in fsspec (fixed in 2026.6.0) for VULN-123548. The FOSSA finding points at the two
test-requirements.txtfiles below, which pinnedfsspec==2025.9.0.From 0.9.0 until 2026.6.0,
fsspec.implementations.reference.ReferenceFileSystemrenders fields of Kerchunk reference JSON documents through unrestrictedjinja2.Template(...).render(...)calls, so a crafted reference document can execute Python code when the reference filesystem is opened. This repository only uses fsspec for its optional artifact upload hook and in tests; it does not useReferenceFileSystem.Changes
util/opentelemetry-util-genai/test-requirements.txt:fsspec==2025.9.0->fsspec==2026.9.0util/opentelemetry-util-genai-evals-deepeval/test-requirements.txt:fsspec==2025.9.0->fsspec==2026.9.0CHANGELOG.mdentries for both packages.Notes
requires-python >=3.9. CI runs Python 3.10-3.13 and does not install thesetest-requirements.txtfiles, so CI is unaffected; a developer on Python 3.9 could not install the new pin.google-genaiandvertexaitest requirements, the traceloop example requirements, and thefsspec>=2025.9.0extras in threepyproject.tomlfiles.Test plan
pip install --dry-runofpytest==9.0.3plusfsspec==2026.9.0resolves on Python 3.13Not run: package tests and
make lint(no code changed); Python 3.10 resolution (not installed locally).