Repository navigation
fix: propagate request cancellation across broker and guests - #85
Merged
Merged
Conversation
9 tasks done
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #83.
AbortSignalsupport and connect Agent, Fetch, and low-level Dispatcher cancellation to the native HTTP/2 stream, including before headers and through internal redirect/replay handling.close/destroyed, Bun handlerRequest.signal, and Python post-upload ASGI disconnect monitoring with cooperative application cleanup and flow-control accounting.createAgent()+node-fetchregressions, real TLS coverage across Node/Bun/Python Guests, and deterministic response-arrival races for the Node Broker, Agent, and modern/legacy Dispatcher. Update cancellation and compatibility documentation.Validation
Current PR head:
6b98807. Hosted validation run passed.compileallpassed.npm run lint: 142 files checked successfully. CodeQL (JavaScript/TypeScript and Python), DCO, and Gitleaks passed.git diff --checkpassed.The current-head hosted run includes the final race tests and documentation. Bun/Python workspace and focused documentation results remain valid because subsequent changes were limited to CI setup and Node test coverage. Local root lint can still encounter four formatting findings in unrelated, untracked
.slim/worktrees/setup-state files; those files are excluded from this PR and did not affect hosted lint.Scope and limitations
node-fetchis a test-only development dependency. No package version bump, release, or publishing operation is included.Checklist
MichalCz.Merge manually through the protected
mainworkflow; this PR must not be merged automatically.