Repository navigation
TT-7618 cleanup offlineproject records when user is removed from team or if t… - #746
Merged
Merged
Conversation
…eam or project is deleted
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The checksum-repair synchronization path passes no user identity, preventing membership deletions from cleaning offline-project records.
1 open finding
What changed in this PR
Cleans stale Orbit offlineproject records when projects, teams, or the current user’s memberships are deleted.
Changes:
- Adds shared offline-project cleanup helpers.
- Integrates cleanup into synchronization and user-removal flows.
- Restores URL-derived plan context and adds regression tests.
| File | Description |
|---|---|
web/src/hoc/processDataChanges.ts |
Cleans offline records during remote deletions. |
web/src/hoc/processDataChanges.offline.test.ts |
Tests synchronized deletion scenarios. |
web/src/crud/useUrlContext.ts |
Restores plan state from URL context. |
web/src/crud/user.ts |
Cleans snapshots when the current user leaves teams. |
web/src/crud/user.removeFromOrg.test.ts |
Tests user-removal cleanup behavior. |
web/src/crud/useOfflnProjDelete.ts |
Uses the shared deletion helper. |
web/src/crud/offlineProjectDelete.ts |
Implements offline-record selection and deletion. |
web/src/crud/offlineProjectDelete.test.ts |
Tests membership-to-project resolution. |
web/src/components/UserTable.tsx |
Supplies cleanup to team-member removal. |
web/src/components/ProfileDialog.tsx |
Supplies cleanup to profile removal. |
web/src/components/ProfileDialog.test.tsx |
Mocks the added deletion hook. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+370
to
+372
| offlineProjectIds.push( | ||
| ...offlineProjectIdsForDeleted(memory, user, table.type, localId) | ||
| ); |
sarahentzel
marked this pull request as ready for review
October 8, 2026 15:07
gtryus
approved these changes
Oct 8, 2026
gtryus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eam or project is deleted