Repository navigation
Conversation
## Summary The desktop and mobile passage-resource lists each had about 1,500 lines of near-duplicate state, handlers and dialogs. Those now live in one hook and one dialogs component. Each view keeps only its own list layout and its text-resource viewer. ```diff Internalization/ -├── PassageDetailArtifacts.tsx # 1571 lines: state + handlers + list + dialogs -├── PassageDetailsArtifactsMobile.tsx # ~1600 lines: same, mobile layout +├── usePassageDetailArtifacts.ts # 1295: Orbit data, state, handlers (shared) +├── PassageDetailArtifactsDialogs.tsx # 432: Uploader + every dialog (shared) +├── PassageDetailArtifacts.tsx # 183: desktop list +└── PassageDetailsArtifactsMobile.tsx # 183: mobile list
Collaborator
|
We still need to fully merge the two using the new design. https://jira.sil.org/browse/TT-7723. This refactor will no longer be necessary after that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop and mobile passage-resource lists each had about 1,500 lines of near-duplicate state, handlers and dialogs. Those now live in one hook and one dialogs component. Each view keeps only its own list layout and its text-resource viewer.