Repository navigation
Replace obsolete OnClosing override in LanguageChoosingDialog - #173
Merged
Merged
Conversation
Form.OnClosing is obsolete in modern WinForms (CS0672/WFDEV004 on net10.0-windows); OnFormClosing is the replacement and exists on every target framework. Adds a test that SelectedLanguage is populated on close. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
October 8, 2026 14:26
andrew-polk
approved these changes
Oct 8, 2026
andrew-polk
left a comment
andrew-polk
left a comment
Contributor
There was a problem hiding this comment.
@andrew-polk reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #165 (see this comment): with the
net10.0-windowstarget,LanguageChoosingDialog.OnClosingtriggersCS0672/WFDEV004becauseForm.OnClosingis obsolete in modern WinForms.OnFormClosing(FormClosingEventArgs)instead, with the same body.OnFormClosingdates from .NET 2.0, so no#ifis needed fornet462/net48.Close()), the X button and Alt+F4 raise bothClosingandFormClosing.FormClosingadditionally fires onApplication.Exit/ owner shutdown, whereClosingdid not._OKButton_Click; otherwise, closing via X would returnnullfromChooseFallbackLanguageWinforms.LanguageChoosingDialogTests.Close_SetsSelectedLanguageFromComboBox. It passes onnet462,net48andnet8.0-windows, and fails if the assignment is removed.No public API change, so no
+semvermarker.🤖 Generated with Claude Code
This change is