Repository navigation
Remove unused TempFile.FromResource(Stream) test helper - #174
Merged
Merged
Conversation
It ignored Stream.Read's return value (CA2022 on net10.0) and wrote a stray trailing zero byte. Nothing calls it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
October 8, 2026 14:28
andrew-polk
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #165 (see this comment): with the
net10.0target,TempFile.FromResource(Stream, string)inL10NSharp.TeststriggersCA2022(inexactStream.Read).Nothing in the solution calls this overload, and it was also subtly wrong: it sized the buffer
resource.Length + 1and wrote the whole buffer, so the file got a stray trailing0x00byte. Rather than fix it with a hand-written read loop (Stream.ReadExactlyisn't available onnet462/net48), this removes it.The
byte[]overload is also unused but triggers no warning, so it stays to keep this change minimal.This change only touches the test project, so it needs no
+semvermarker or changelog entry.🤖 Generated with Claude Code
This change is