Repository navigation
Add validate --allow CODE to leave a code out of pass/fail - #48
Merged
Merged
Conversation
validate --allow CODE (repeatable) reports a code's findings but excludes them from the error and warning counts, so they neither fail the run nor trip --strict. It applies to error-level codes as well as warnings. The text summary line tallies allowed findings per code, and the JSON summary gains an allowed total. A code that never occurs is ignored. The GitHub Action gains an allow input taking codes separated by commas, spaces, or newlines. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
imnasnainaec
added
enhancement
A value with CRLF line breaks left a trailing \r on each code, so no code matched a finding and nothing was allowed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jasonleenaylor
previously approved these changes
Oct 2, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
One question and one nit inline. LGTM.
This review was assisted by Claude Fable 5.1.
`--allow a,b` previously matched no code and was silently ignored, unlike the Action's allow input, which already takes a list. Split each value on commas so both forms work. Also reword the exit-code note so "warnings allowed" is not read as referring to --allow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`--allow "schema, form-missing-lang"` kept the leading space on the second code, so it matched nothing and its findings still failed the run. Strip each comma-separated piece, matching the Action's allow input, which already splits on whitespace as well as commas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
🤖 Generated with Claude Code
This change is