Correct the lengths for the "get" shortcut container functions - #474
Open
ridiculousfish wants to merge 1 commit into
Open
Correct the lengths for the "get" shortcut container functions#474ridiculousfish wants to merge 1 commit into
ridiculousfish wants to merge 1 commit into
Conversation
Containers in simd-json are represented via a header node, followed by the contained nodes. Thus the number of nodes should be one more than the length of the container. This +1 was correctly applied in "get/try_get" path followed by as_array/as_object, but was missed in the typed shortcut functions such as "get_array" or "try_get_array." Thus "try_get" would return arrays and objects missing their last element; or an invalid object if the array was empty. Correct this and add a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Containers in simd-json are represented via a header node, followed by the contained nodes. Thus the number of nodes should be one more than the length of the container.
This +1 was correctly applied in "get/try_get" path followed by as_array/as_object, but was missed in the typed shortcut functions such as "get_array" or "try_get_array." Thus "try_get" would return arrays and objects missing their last element; or an invalid object if the array was empty.
Correct this and add a test.