Repository navigation
Windows native player and floating PiP (alpha) - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The Windows embedded MPV renderer gains an app-owned floating Picture in Picture window with hover controls, guarded seeking and clipping that keeps Angular controls usable without resizing the video. Opening minimized PiP restores the existing hosts. Returning or closing restores the main window; automatic disposal leaves focus alone. Playback keeps its session and provider connection.
This is the personal-fork integration of an optional upstream proposal. Browser PiP already exists upstream; this contribution adds the specialized Windows native window and shared capability/timeline refinements. External-player availability and earlier fork CI maintenance are already in the base and are not additions in this diff.
Alpha. Only Windows has been used for manual feature testing. macOS/Linux native and PiP runtime behavior remains unverified.
Corrections and validation
Current integration
0d757a0280670a06e88ab1a9863055a41bd43a8aincludes both corrections to the previous matrix: playback policies use dedicated public subpath imports so they stay outside the startup bundle, and backend coverage excludes standalone HTML while retaining executable TS/JS/MJS instrumentation. Neither performance nor coverage limits was lowered.0d757a028accepted all 34 coverage reports and unchanged health gates: statements 83.10%, branches 74.35%, functions 81.34%, lines 83.48%.0d757a028in review round two with no actionable regressions. Its own noninteractive dependency bootstrap aborted, so it did not run tests; the execution checks above ran separately on this same head. Greptile CLI is unavailable and was not run.Publication gate
All 29 checks passed on
0d757a028: CI, cross-platform E2E, packaging, CodeQL and Docker. This includes every Windows/Linux/macOS Electron shard and the previously failing startup-size and coverage gates. The optional upstream proposal is PR #1827.Corrected source
85b2d910277eb133f8d626d90994a2bfde5291edmerges conflict-free with actual upstream master2738bc28a1335ff19f87d67c5b1bbec3881b8e85. Current upstream itself has a failing performance-inventory check, involvingserial-details.test-stubs.ts. Fork CI tests baselinebf3cf87b6plus separately reviewed maintenance and is not proof of green latest-upstream integration. No automatic upstream merge is requested.Release note:
.changes/windows-native-mpv-alpha.md.