Remove extraneous prefix in Redis - #58
Merged
Merged
Conversation
Contributor
Author
|
I see the workflow fails because of a rate limit. But phpunit/phpstan/phpcs run cleanly for me. So hopefully I've not introduced anything that breaks @tvdijen's tidy of the original code. |
Member
|
I'm aware of the ratelimit-issue, just have to find the time to fix it across ~90 repositories |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation in #57 duplicates the prefix, resulting in keys that contain SimpleSAMLphp twice (i.e.,
SimpleSAMLphpSimpleSAMLphpconsent:fooinstead ofSimpleSAMLphpconsent:foo). That's because predis automatically applies the prefix, so it doesn't need to be added manually to every key.While things are functional as they are, anyone looking at the store will see the duplication, and it was not intended. So, before there are too many deployments, I thought to fix it.