improvement(settings): consolidate access requests in settings #32587
waleedlatif1ci.yml
on: pull_request
Detect Version
Detect Desktop Changes
0s
Prepare Trigger.dev
0s
Matrix: Build AMD64
Matrix: Build Dev ECR
Matrix: Build ARM64 (GHCR Only)
Matrix: Test and Build / oauth-postgres
Matrix: Test and Build / test-shard
Test and Build
/
Lint and Test
2m 35s
Test and Build
/
Build App
3m 20s
Check Docs Changes
Migrate Dev DB
/
Apply Database Migrations
Matrix: Create GHCR Manifests
Process Docs
/
Process Documentation Embeddings
Promote Trigger.dev
Prune Desktop Prereleases
0s
Matrix: Attest Images
Desktop Release
/
Build, Sign, Notarize
Annotations
5 errors and 6 warnings
|
Test and Build / Test (shard 3)
Process completed with exit code 1.
|
|
app/workspace/[workspaceId]/settings/navigation.test.ts > unified settings navigation > orders each scope around its primary settings:
apps/sim/app/workspace/[workspaceId]/settings/navigation.test.ts#L72
AssertionError: expected [ Array(13) ] to deeply equal [ 'teammates', 'secrets', 'mcp', …(9) ]
- Expected
+ Received
@@ -9,6 +9,7 @@
"inbox",
"workflow-mcp-servers",
"apikeys",
"sandboxes",
"recently-deleted",
+ "requests",
]
❯ app/workspace/[workspaceId]/settings/navigation.test.ts:72:40
|
|
app/workspace/[workspaceId]/settings/navigation.test.ts > unified settings navigation > keeps account, workspace, organization, and platform settings in one catalog:
apps/sim/app/workspace/[workspaceId]/settings/navigation.test.ts#L23
AssertionError: expected [ { id: 'general', …(2) }, …(30) ] to deeply equal [ { id: 'general', …(2) }, …(30) ]
- Expected
+ Received
@@ -20,11 +20,11 @@
"section": "account",
},
{
"id": "requests",
"label": "Requests",
- "section": "organization",
+ "section": "workspace",
},
{
"id": "access-control",
"label": "Permission groups",
"section": "organization",
❯ app/workspace/[workspaceId]/settings/navigation.test.ts:23:90
|
|
Test and Build / Test (shard 3)
@sim/app#test: command (/home/runner/_work/sim/sim/apps/sim) /home/runner/.bun/bin/bun run test exited (1)
|
|
Test and Build / Lint and Test
Process completed with exit code 1.
|
|
Test and Build / Test (shard 3)
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Test (shard 3)
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Test (shard 3)
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Test (shard 3)
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Test (shard 3)
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Test (shard 3)
Found 2 failed/cancelled steps in previous workflow steps
|