Skip to content

improvement(settings): consolidate access requests in settings - #8154

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/requests-in-settings
Sep 22, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/requests-in-settings

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Move personal requests and access browsing into Settings → Requests on both workspace and organization surfaces, alongside the existing admin review queue.
  • Keep workspace scope and standard settings navigation, remove the duplicate profile entry, and preserve saved links and email selections through canonical redirects.

Type of Change

  • Improvement

Testing

344 focused tests passed, covering requester and admin views, role boundaries, navigation, saved links, and notification destinations. Checked populated and empty component previews in light and dark themes. Full lint and type-check across 26 workspaces, all 47 audits (including API boundary validation), generators, block registry, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:30pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 32 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues identified.

Summary

This PR consolidates requester and administrator access-request workflows under Settings → Requests while preserving legacy links and scope-specific navigation.

  • Adds a unified requests settings component with requester, catalog, and administrator review views.
  • Keeps workspace request history scoped to the current workspace while exposing organization review only to eligible administrators.
  • Redirects legacy workspace, organization, and email URLs to canonical settings destinations while retaining query state.
  • Updates settings navigation, notifications, documentation, and focused tests for the consolidated experience.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Legacy or current request link] --> B{Scope}
    B -->|Workspace| C[Workspace Settings / Requests]
    B -->|Organization| D{Organization settings shell available?}
    D -->|Yes| E[Organization Settings / Requests]
    D -->|No| F[Standalone Requests settings shell]
    C --> G[My requests and Browse access]
    E --> G
    F --> G
    E --> H{Organization administrator?}
    F --> H
    H -->|Yes| I[Review requests]
    H -->|No| G
Loading

Reviews (2) · Last reviewed commit: "fix(settings): update requests navigatio..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 33 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5242e46 into staging Sep 22, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/requests-in-settings branch September 22, 2026 20:36

This branch was previously deployed

1 inactive deployment
Preview — 8cbe5983 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant