Skip to content

fix(search): preserve filters and report incomplete results - #7855

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-filter-continuity
Sep 15, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-filter-continuity

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep source and date filters mounted through loading, empty, incomplete, and failed searches, preserving keyboard focus and one rolling date anchor per query.
  • Retain previous matches only while refining the same query, reader, and resource scope. Clear them after access resets and avoid summarizing old matches with new filters.
  • Distinguish incomplete results from confirmed empty results, expose retry, and report partial completion in the existing content-free search diagnostics.

Type of Change

  • Bug fix

Testing

  • Real React Query and Nuqs transition tests cover focus, cancellation, late responses, scope changes, access resets, invalidation, URL updates, and retry.
  • Organization search page, query hooks, access-cache reconciliation, and diagnostic tests pass.
  • Disposable PostgreSQL/pgvector integration suite covers the dashboard and Assistant, forced retrieval deadlines, access isolation, and revocation.
  • Type-check, lint, all repository audits, API boundary validation, and generated-artifact checks pass. Manually checked the local search controls through loading, empty, failure, and recovery.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 6:41pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

Summary

This PR preserves search controls and carefully scoped previous results across filter refinements, partitions cached searches by reader, distinguishes partial retrieval from confirmed empty results, and exposes retry behavior.

  • Keeps source and rolling-date filters mounted across loading, failure, empty, and partial states.
  • Reuses prior matches only for the same query, reader, and resource scope.
  • Reports partial retrieval separately in both the UI and content-free diagnostics.
  • Adds transition, cache isolation, retry, diagnostic, and integration coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Query, resource scope, reader] --> B[Mount scoped SearchResults]
  B --> C[Fix rolling-date anchor]
  C --> D[Build source and date filters]
  D --> E[Reader-partitioned React Query key]
  E --> F{Cached same-query refinement?}
  F -->|Valid and not invalidated| G[Show previous matches as placeholder]
  F -->|No| H[Show fresh search state]
  G --> I[Run filtered search]
  H --> I
  I --> J{Retrieval outcome}
  J -->|Complete with matches| K[Show matches]
  J -->|Complete and empty| L[Show confirmed empty state]
  J -->|Partial| M[Show incomplete status and retry]
  J -->|Failure| N[Show failure and retry]
Loading

Reviews (1) · Last reviewed commit: "fix(search): preserve filters and report..."

@waleedlatif1
waleedlatif1 merged commit bb20239 into staging Sep 15, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-filter-continuity branch September 15, 2026 19:12

This branch was previously deployed

1 inactive deployment
Preview — 92a45c8d Deployed Sep 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant