feat(access-requests): request and review permission access - #7871
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
There was a problem hiding this comment.
2 issues found across 109 files
Confidence score: 3/5
- In
apps/sim/ee/access-control/components/access-control.tsx, thepermission-access-requestsrollout gate can be bypassed, allowing admins to view request history and change the organization opt-out; gateOrganizationAccessRequestsand its controls behind the flag. - In
apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx, the wrapper causes existing knowledge component tests to fail before rendering becauseKnowledgeis mounted without React Query context; mockPermissionAccessBoundaryinknowledge.test.tsxor render the required context.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx">
<violation number="1" location="apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx:199">
P2: This wrapper breaks the existing knowledge component tests before the list renders because they mount `Knowledge` without React Query context. Mock `PermissionAccessBoundary` in `knowledge.test.tsx` or render the test through a `QueryClientProvider`.</violation>
</file>
<file name="apps/sim/ee/access-control/components/access-control.tsx">
<violation number="1" location="apps/sim/ee/access-control/components/access-control.tsx:71">
P2: When `permission-access-requests` is disabled, this switch still exposes `OrganizationAccessRequests`; admins can view request history and change the organization opt-out despite the rollout gate. Gate this view and its settings mutations on the global flag.</violation>
</file>
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
a5e7dae to
e1db271
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 129 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
The latest summary appears to include changes inherited from staging during the rebase. The retired-column migration 0348 and its backfill/dev schema-push changes are already in the staging base (commit 783cf17); they are absent from this PR's current diff against staging. The migration introduced here is 0349_permission_access_requests.sql, which adds the access-request and organization-preference tables. This PR does not change packages/db/scripts or .github/workflows/test-build.yml. Please reassess the current staging-to-HEAD PR diff rather than the previous-head-to-current-head comparison. The access-request migration safety checks and both PostgreSQL CI modes passed. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
Checklist