improvement(ui): share browser toolbar actions by BillLeoutsakosvl346 · Pull Request #8068 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-20T22:49:12Z

Summary

Share five browser navigation and utility actions through one local EMCN Button composition.
Preserve 30px geometry, menu anchor refs, disabled navigation and download progress content.

Type of Change

Refactor / maintainability improvement

Testing

Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
External source comparison confirms caller logic and content are unchanged.
Original and extracted components have matching computed styles in light/dark browser fixtures; keyboard, disabled and expansion behavior checked. These are isolated fixtures, not full authenticated product flows.
Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-20T22:49:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 10:26pm UTC

greptile-apps · 2026-09-20T22:51:22Z

Confidence Score: 5/5

The PR appears safe to merge; the latest change fully restores the toolbar controls’ original 30px footprint without altering their behavior.

Summary

This PR extracts five browser navigation and utility controls into a shared BrowserToolbarButton composition while preserving refs, events, disabled states, download content, and the original 30px footprint.

Centralizes the shared EMCN Button configuration.
Retains menu-trigger ref forwarding and native button behavior.
The latest change restores the documented 30px toolbar geometry.

_{Reviews (6) · Last reviewed commit: "fix(ui): preserve browser toolbar button..."}

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-20T22:57:11Z

@greptile

BillLeoutsakosvl346 · 2026-09-20T22:57:12Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-20T22:57:18Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T17:57:25Z

Before / after visual comparison

Browser Back/Forward controls share BrowserToolbarButton, preserving the 30px treatment and disabled appearance.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: ef148b6db6.

BillLeoutsakosvl346 · 2026-09-22T19:59:22Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T19:59:23Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T19:59:28Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T20:14:42Z

@greptile Please re-review the current head; each finding has a response and the applicable fixes are pushed.

BillLeoutsakosvl346 · 2026-09-22T20:14:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T20:14:49Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

BillLeoutsakosvl346 · 2026-09-24T22:20:48Z

@greptile Please review the new head after the conflict resolution against #7991.

BillLeoutsakosvl346 · 2026-09-24T22:20:52Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:20:56Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:27:24Z

@greptile Please re-review the current head ba75192 after the 30px toolbar geometry fix.

BillLeoutsakosvl346 · 2026-09-24T22:27:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:27:38Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

vercel Bot temporarily deployed to Preview September 20, 2026 22:49 Inactive

greptile-apps Bot reviewed Sep 20, 2026

View reviewed changes

Comment thread ...rship-view/components/resource-content/components/browser-session/browser-toolbar-button.tsx Outdated

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 20, 2026 22:57 Inactive

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

Bill Leoutsakos added 2 commits September 22, 2026 12:20

improvement(emcn): share ordinary action geometry in Button

d583476

improvement(ui): share browser toolbar actions

c7627f6

BillLeoutsakosvl346 changed the base branch from staging to codex/overrides-button-sizing September 22, 2026 19:59

BillLeoutsakosvl346 force-pushed the codex/control-fix-browser-toolbar-actions branch from ef148b6 to c7627f6 Compare September 22, 2026 19:59

vercel Bot temporarily deployed to Preview September 22, 2026 19:59 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread ...rship-view/components/resource-content/components/browser-session/browser-toolbar-button.tsx Outdated

refactor(ui): remove redundant browser action client boundary

c26c5df

vercel Bot temporarily deployed to Preview September 22, 2026 20:14 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

improvement(ui): use regular geometry for browser actions (#8157)

fe51709

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

vercel Bot temporarily deployed to Preview September 23, 2026 02:11 Inactive

Base automatically changed from codex/overrides-button-sizing to codex/control-fix-icon-button-sizing September 23, 2026 02:12

Merge icon button sizing into browser toolbar actions

20f2fc9

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

vercel Bot deployed to Preview September 24, 2026 22:22 View deployment

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...rship-view/components/resource-content/components/browser-session/browser-toolbar-button.tsx Outdated

fix(ui): preserve browser toolbar button footprint

ba75192

vercel Bot temporarily deployed to Preview September 24, 2026 22:26 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 5c042a0 into codex/control-fix-icon-button-sizing Sep 24, 2026
5 checks passed

waleedlatif1 deleted the codex/control-fix-browser-toolbar-actions branch September 24, 2026 23:57

BillLeoutsakosvl346 mentioned this pull request Sep 25, 2026

refactor(ui): centralize compact icon button sizing in EMCN #7991

Open

Conversation

BillLeoutsakosvl346 commented Sep 20, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Before / after visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Sep 20, 2026 •

edited

Loading

greptile-apps Bot commented Sep 20, 2026 •

edited

Loading