Skip to content

fix(knowledge): skip global readiness checks for ordinary KBs - #8212

Merged
TheodoreSpeaks merged 3 commits into
stagingfrom
codex/investigate-native-canary-knowledge
Sep 23, 2026
Merged

TheodoreSpeaks merged 3 commits into
stagingfrom
codex/investigate-native-canary-knowledge

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Ordinary KB vector searches can exhaust their retrieval deadline while waiting on a global projection-readiness check. Skip that probe unless every searched KB is a Sim Search index.
  • Retain document-backed identity reads and permission checks for ordinary KBs, and preserve the existing Sim Search path. Cover both paths with retrieval, denied-source, and deadline tests.

Type of Change

  • Bug fix

Testing

  • 199 focused tests passed across search queries, ACL predicates, and the search application use case.
  • All 3 PostgreSQL KB block integration tests passed locally, including 18 concurrent searches with and without tag filters. Assertions verify zero global readiness probes and document-backed page reads.
  • App type-check and repository-wide lint passed.
  • All 47 repository audits, the staging block-registry check, and docs-manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 23, 2026 11:49pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the new branch preserves authorization behavior while removing the problematic global readiness query from ordinary KB searches.

Summary

This PR prevents ordinary knowledge-base vector searches from spending their retrieval deadline on the global projection-readiness probe while preserving the existing Sim Search behavior.

  • Adds searchIndexOnly to distinguish all-Sim-Search requests from ordinary or mixed KB searches.
  • Uses the readiness probe only for all-Sim-Search requests.
  • Keeps ordinary KB candidate authorization and denied-source handling document-backed.
  • Expands retrieval, deadline, and denied-source coverage for both paths.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Vector knowledge search] --> B{Every KB is a Sim Search index?}
  B -->|Yes| C[Check global projection readiness]
  C --> D{Projection filled?}
  D -->|Yes| E[Use projected on-row identity path]
  D -->|No| F[Use document-backed identity path]
  B -->|No| F
  E --> G[Rank, authorize, and hydrate results]
  F --> G
Loading

Reviews (1) · Last reviewed commit: "fix(knowledge): skip global readiness ch..."

@TheodoreSpeaks
TheodoreSpeaks merged commit 11cba52 into staging Sep 23, 2026
33 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/investigate-native-canary-knowledge branch September 24, 2026 00:00

This branch was successfully deployed

1 active deployment
Preview — c51df9c5 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant