Skip to content

fix(search): add GitHub commit search and accept native-only live queries - #8228

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/live-search-tool-failures-and-titles
Sep 24, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/live-search-tool-failures-and-titles

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Add a GitHub commits search kind. The Assistant had no way to answer "what did I commit this week", so it tried the code and issues kinds with commit qualifiers, and those calls failed
    • /search/commits uses the same repository scoping as issues. Date bounds become one author-date: range, and date ordering sorts by author-date
    • read_document on a commit calls GET /repos/{repo}/commits/{sha}. It returns the message plus up to 30 changed files (GitHub's default page size), since each file carries its full patch. The sha is validated before any request
    • Commits verify at repository level, like issues. Commit search needs only the Contents read permission the App already requires
    • Commits are searched only when the kind is explicit, so default searches spend no extra search requests
  • Accept a search_workspace call whose only search terms are in a native query (e.g. author:@me). The contract and the use case previously rejected it with "Supply search terms or a date bound"
  • Regenerate the tool catalog and runtime schemas. The worker's copy of the assistant tool contract ships in the paired copilot PR

Type of Change

  • Bug fix

Testing

  • Unit tests: commit search query, sort and mapping; the author-date range; commit reads; invalid refs; native-only validation in the contract and the use case
  • Ran the real searchGitHub/readGitHub against the live GitHub API:
    • The failing "commits this past week" call now returns only in-range commits
    • Oldest and newest sort, bounded ranges and pagination work
    • Short-sha reads work, and bad refs are rejected
    • Issue and default-kind searches behave as before
  • Checked against GitHub's REST docs (search commits, get a commit, commit search qualifiers)
  • bun run lint, check:audits, mship-tools:check, type-check and the lib/sim-search, lib/mothership and contract suites pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 7:14am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge based on the reviewed changes and resolved findings.

Summary

The PR adds explicit GitHub commit search and commit reads, permits native-query-only live searches, and updates the Assistant contracts, generated schemas, tests, and guidance.

  • The change since the previous review fixes date-qualifier detection for quoted phrases.
  • No new actionable issue was established. All previous Greptile threads are resolved.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Native-only search request] --> B[Validate search contract]
  B --> C[Live search]
  C --> D[GitHub commit query with author-date bounds]
  D --> E[Commit results]
  E --> F[Repository-scoped commit read]
Loading

Reviews (3) · Last reviewed commit: "fix(search): detect native GitHub date q..."

Comment thread apps/sim/lib/sim-search/live/application.ts
Comment thread apps/sim/lib/sim-search/live/github.ts Outdated
Comment thread apps/sim/lib/sim-search/live/README.md Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/lib/sim-search/live/github.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 05ed98d into staging Sep 24, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/live-search-tool-failures-and-titles branch September 24, 2026 15:26

This branch was previously deployed

1 inactive deployment
Preview — 15b9822c Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant