Repository navigation
fix(search): add GitHub commit search and accept native-only live queries - #8228
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitssearch kind. The Assistant had no way to answer "what did I commit this week", so it tried thecodeandissueskinds with commit qualifiers, and those calls failed/search/commitsuses the same repository scoping as issues. Date bounds become oneauthor-date:range, and date ordering sorts byauthor-dateread_documenton a commit callsGET /repos/{repo}/commits/{sha}. It returns the message plus up to 30 changed files (GitHub's default page size), since each file carries its full patch. The sha is validated before any requestsearch_workspacecall whose only search terms are in a native query (e.g.author:@me). The contract and the use case previously rejected it with "Supply search terms or a date bound"Type of Change
Testing
author-daterange; commit reads; invalid refs; native-only validation in the contract and the use casesearchGitHub/readGitHubagainst the live GitHub API:bun run lint,check:audits,mship-tools:check, type-check and thelib/sim-search,lib/mothershipand contract suites passChecklist