Skip to content

improvement(logs): refresh the table on demand - #8235

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/logs-manual-refresh
Sep 24, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/logs-manual-refresh

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the logs table stable until Refresh is clicked, with a new-log count and the existing activity-dot styling.
  • Check for new runs with filtered count-only queries. A slower revision check catches late-visible and newly matching older rows, then stops until Refresh.
  • Preserve resolved date bounds across pagination and stop appending pages if membership or sort values change. Keep open run details live.
  • Preserve confirmed run status when cancellation finishes with a different terminal result.

Type of Change

  • Improvement

Testing

  • 38 focused logs tests passed, including polling, pagination, revision changes, refresh failures, filters, and cancellation reconciliation.
  • App type-check, full lint checks, all 49 repository audits, block-registry audit, and docs-manifest check passed.
  • Previewed the shared toolbar in light and dark themes, including refresh and tooltip states.
  • Verified revision SQL and query plans with synthetic data on local PostgreSQL.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 6:23pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with a non-blocking delay to manual Refresh while a page loads.

Findings

  1. P2 Pagination blocks Refresh ▶

Summary

The PR keeps log rows fixed until Refresh, adds count and revision checks for changes, validates pagination against the snapshot, and reconciles cancelled runs. The remaining finding is a non-blocking Refresh-control regression during pagination.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Load snapshot and revision] --> B[Display fixed pages]
  A --> C[Poll new-run count]
  A --> D[Poll snapshot revision]
  C --> E[Show new-log count]
  D --> F[Show updates available]
  B --> G[Load next page]
  G --> H{Revision unchanged?}
  H -- Yes --> B
  H -- No --> F
  E --> I[Refresh clicked]
  F --> I
  I --> A
Loading

Reviews (2) · Last reviewed commit: "fix(logs): detect snapshot changes befor..."

Comment thread apps/sim/lib/logs/list-logs.ts
Comment thread apps/sim/hooks/queries/logs.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/hooks/queries/logs.ts Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/logs/logs.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/app/workspace/[workspaceId]/logs/logs.tsx
@waleedlatif1
waleedlatif1 merged commit 1fa912f into staging Sep 24, 2026
34 of 35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/logs-manual-refresh branch September 24, 2026 19:15

This branch was previously deployed

1 inactive deployment
Preview — a86e3123 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant