refactor(ui): remove duplicate EMCN Label colours - #8242
Merged
Merged
Conversation
Contributor
Author
|
@greptile review this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
Contributor
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
Remove 27 exact
text-[var(--text-primary)]repetitions from product callers of EMCN Label. The colour already comes from the Label base recipe; markup, local geometry, and interaction remain unchanged.Scope and visual decision
Targets live staging at
316fea02ec. The local design diff check against this base completes with zero new findings. The earlier suggestion to deletetext-smallandleading-nonewas rejected after computed-style captures showed line-height changes, so this PR leaves those treatments for a separate design decision.Validation
Visual comparison
Representative matched captures from the local source-derived fixture. Before uses this PR’s base; after uses this PR’s head. Full light/dark and root-size matrices are retained outside the product branch.
Light · 16px root text · default
Dark · 20px root text · default