Skip to content

refactor(ui): remove duplicate EMCN Label colours - #8242

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/emcn-next-label-defaults
Sep 25, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/emcn-next-label-defaults

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remove 27 exact text-[var(--text-primary)] repetitions from product callers of EMCN Label. The colour already comes from the Label base recipe; markup, local geometry, and interaction remain unchanged.

Scope and visual decision

Targets live staging at 316fea02ec. The local design diff check against this base completes with zero new findings. The earlier suggestion to delete text-small and leading-none was rejected after computed-style captures showed line-height changes, so this PR leaves those treatments for a separate design decision.

Validation

  • Sixteen focused tests, app type check, Biome, and diff whitespace check passed.
  • All 27 Label sites were compared in source-derived before/after captures. Computed styles and pixels match in light/dark at 16px and 20px root text. Evidence is stored outside the product checkout.
  • Independent source review confirmed all 27 removals are byte-for-byte duplicates of the EMCN Label colour.
  • Full comparable scans and both bot reviews are pending; keep this PR unmerged until all required checks and threads are complete.

Visual comparison

Representative matched captures from the local source-derived fixture. Before uses this PR’s base; after uses this PR’s head. Full light/dark and root-size matrices are retained outside the product branch.

Light · 16px root text · default

Before After
labels before, light mode, 16px root text, default labels after, light mode, 16px root text, default

Dark · 20px root text · default

Before After
labels before, dark mode, 20px root text, default labels after, dark mode, 20px root text, default

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile review this PR

@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 6:48pm UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The code changes appear safe to merge; no actionable issue was identified.

Summary

Removes duplicate text-colour classes from 27 EMCN Label callers across deployment forms, editor controls, and workflow previews. The Label component continues to supply the same colour.

Reviews (1) · Last reviewed commit: "refactor(emcn): remove duplicate Label p..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Visual review: EMCN Label colour defaults

What changed: This PR removes 27 call-site copies of text-[var(--text-primary)] from Label. EMCN Label already supplies that colour; each caller keeps its own spacing and type classes. No label behaviour or component API changes.

// Before — deploy modal, “Language” label
<Label className='block pl-0.5 text-[var(--text-primary)] text-small'>Language</Label>

// After
<Label className='block pl-0.5 text-small'>Language</Label>

What to inspect: The label text colour, baseline, and spacing should be identical. This is a labeled isolated fixture using the actual EMCN Label and 27 class pairs extracted from staging 316fea02ec; it is not an authenticated workflow capture. The current PR diff at 420294c425f9 still contains the same 27 token removals. All 27 computed appearances and all four before/after PNG pairs are identical in this fixture.

Theme / root text Before After
Light / 16px Before Label, light 16px After Label, light 16px
Dark / 16px Before Label, dark 16px After Label, dark 16px
Light / 20px Before Label, light 20px After Label, light 20px
Dark / 20px Before Label, dark 20px After Label, dark 20px

@waleedlatif1
waleedlatif1 merged commit ab16777 into staging Sep 25, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/emcn-next-label-defaults branch September 25, 2026 00:15

This branch was previously deployed

1 inactive deployment
Preview — 420294c4 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants