refactor(auth): share loading skeleton treatments - #8254
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Author
|
@greptile review this PR |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
Contributor
Author
|
@greptile review this PR |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Contributor
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
Share the repeated auth loading skeleton geometry across login, signup, SSO, reset-password, and verification loading routes. Keep route-specific widths, spacing, and placeholder counts while using the existing EMCN Skeleton.
Base and validation
Targets live staging at
1fa912f71f(rebased without changing the patch). The app type check with this branch's own dependencies, three route-focused tests, five shared-shape tests, Biome, and diff whitespace check passed. Independent source review found no blockers.The five actual route components render the same 38 placeholders before and after. Isolated captures show identical computed positions, sizes, radii, backgrounds, and RGB pixels in light/dark at 16px/20px root size; the auth shell retains its forced-light surface inside dark surroundings. Evidence is stored outside the product checkout.
The local design diff check (3.10.7) against exact staging base
1fa912f71fand product head0efa8a30bcreports three fixed-radius source findings in the new shared auth recipe, with no coverage failures. They preserve the existing 4px, 10px, and 1px loading shapes; all three match unique fingerprints in the external reviewed-Extra ledger, with no stale or ambiguous decisions. Raw findings remain visible. The follow-up commita825012953adds only a test file, so product styling is unchanged. A comparable full scan is coordinated outside this PR. Keep this PR unmerged until both bot reviews, required checks, and all review threads are complete.