Skip to content

refactor(auth): share loading skeleton treatments - #8254

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/emcn-next-auth-loading
Sep 25, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/emcn-next-auth-loading

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Share the repeated auth loading skeleton geometry across login, signup, SSO, reset-password, and verification loading routes. Keep route-specific widths, spacing, and placeholder counts while using the existing EMCN Skeleton.

Base and validation

Targets live staging at 1fa912f71f (rebased without changing the patch). The app type check with this branch's own dependencies, three route-focused tests, five shared-shape tests, Biome, and diff whitespace check passed. Independent source review found no blockers.

The five actual route components render the same 38 placeholders before and after. Isolated captures show identical computed positions, sizes, radii, backgrounds, and RGB pixels in light/dark at 16px/20px root size; the auth shell retains its forced-light surface inside dark surroundings. Evidence is stored outside the product checkout.

The local design diff check (3.10.7) against exact staging base 1fa912f71f and product head 0efa8a30bc reports three fixed-radius source findings in the new shared auth recipe, with no coverage failures. They preserve the existing 4px, 10px, and 1px loading shapes; all three match unique fingerprints in the external reviewed-Extra ledger, with no stale or ambiguous decisions. Raw findings remain visible. The follow-up commit a825012953 adds only a test file, so product styling is unchanged. A comparable full scan is coordinated outside this PR. Keep this PR unmerged until both bot reviews, required checks, and all review threads are complete.

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 7:29pm UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile review this PR

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge from this review; no outstanding code findings remain.

Summary

The PR moves auth loading-placeholder shapes and repeated compositions into shared components while retaining route-specific widths, spacing, and counts.

  • Adds focused tests for the shared shapes and compositions.
  • The previously requested test coverage is present; the import-order thread was manually resolved.

Reviews (2) · Last reviewed commit: "test(auth): cover shared loading shapes ..."

Comment thread apps/sim/app/(auth)/components/auth-loading-skeleton.tsx
Comment thread apps/sim/app/(auth)/components/auth-loading-skeleton.tsx
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile review this PR

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Visual review: shared auth loading skeletons

What changed: The five auth loading routes now compose shared auth-owned skeleton shapes and field/action groups. Route-specific widths, margins, and field counts remain at each call site. The shapes retain the same 38px title, 14px label, 44px control, and 1px divider geometry.

// Before — login loading field
<div className='mt-8 w-full space-y-2'>
  <Skeleton className='h-[14px] w-[40px] rounded-[4px]' />
  <Skeleton className='h-[44px] w-full rounded-[10px]' />
</div>

// After
<AuthLoadingField labelWidthClassName='w-[40px]' className='mt-8' />

What to inspect: Placeholder widths, gaps, radii, and alignment. These are labeled isolated renders of the actual auth loading components with compiled product CSS, using staging 316fea02ec source for Before. They are not captures of a live sign-in request. The styling patch was rebased unchanged onto staging 1fa912f71f; current PR head is a8250129539f. All 38 placeholders have matching computed position, size, radius, and background, and the four screenshot pairs are byte-identical. In dark mode the auth surface remains forced light, as in the product shell.

Page theme / root text Before After
Light / 16px Before auth loading, light 16px After auth loading, light 16px
Dark / 16px Before auth loading, dark 16px After auth loading, dark 16px
Light / 20px Before auth loading, light 20px After auth loading, light 20px
Dark / 20px Before auth loading, dark 20px After auth loading, dark 20px

@waleedlatif1
waleedlatif1 merged commit 7b21069 into staging Sep 25, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/emcn-next-auth-loading branch September 25, 2026 00:11

This branch was previously deployed

1 inactive deployment
Preview — a8250129 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants