Skip to content

fix(tabs): preserve readable labels in crowded tab strips - #8319

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/preserve-active-tab-labels
Sep 26, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/preserve-active-tab-labels

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep floating tab titles readable when selecting, hovering, or focusing crowded tabs. Use a stable 112px minimum, with room for both attention and close controls on touch devices; overflow scrolls instead of collapsing labels.
  • Reuse EMCN's spacing scale, shared scroll fade, and matching active-tab scroll margin.
  • Extend the real Electron regression test to measure usable title space and verify stable hover geometry, keyboard reveal, touch controls, and light/dark screenshots.

Type of Change

  • Bug fix

Testing

  • Real Electron browser-chrome.spec.ts passes, including existing native-browser overlay coverage. The selected-title regression fails on the previous implementation (2px of title space), and removing the touch minimum independently reproduces its failure (20px).
  • Reviewed crowded-tab screenshots in both themes and touch mode; artifacts are produced through Playwright's configurable output directory.
  • Tab-strip unit test; app, desktop, and EMCN type checks; cleanup review; repository lint; block-registry audit; all 51 check:audits checks; docs-manifest check; git diff --check pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 26, 2026 5:53am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/tab-strip/tab-strip.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Updates tab strip rendering and test fixtures for label visibility.

The PR appears safe to merge; no outstanding finding or new actionable issue was established.

Summary

The PR gives crowded floating tabs a stable readable width, reserves space for touch controls, reuses the shared scroll fade, and extends the Electron regression test. The previous findings are resolved or addressed by the current code.

Reviews (3) · Last reviewed commit: "fix(tabs): keep touch sizing stable acro..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

Comment thread apps/desktop/e2e/browser-chrome.spec.ts
Comment thread apps/desktop/e2e/browser-chrome.spec.ts
@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread packages/emcn/src/components/tab-strip/tab-strip.tsx
Comment thread apps/desktop/e2e/browser-chrome.spec.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5126dc6 into staging Sep 26, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/preserve-active-tab-labels branch September 26, 2026 06:57

This branch was successfully deployed

1 active deployment
Preview — 9f8d3e70 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant