Skip to content

fix(execution): bound reference and context processing - #8344

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/bound-reference-processing
Sep 26, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/bound-reference-processing

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Replace repeated Function tag and workflow-variable rewrites with single passes and cached bindings. Bound executable and diagnostic source length and reference count before execution, preserving legacy variable precedence.
  • Reuse sanitized documentation queries across contexts and match context labels in bounded passes. Limit messages to 1,048,576 characters, contexts to 100, and labels to 1,000 characters at admission and context resolution.
  • Index workflow dependencies by block and path. Bound input traversal, text, references, and mock path depth, returning an explicit error when the command cannot produce a complete report.

Type of Change

  • Bug fix

Testing

  • 464 tests passed across 15 touched and neighboring test files, including Function execution, chat context processing/admission, workflow dependency commands, and headless execution.
  • The new limit regressions failed before their fixes. Independently disabling each input limit and the incremental object-traversal and legacy-precedence protections made the corresponding regressions fail again; all guards were restored.
  • Lint, all 51 repository audits, type-checking across 26 workspaces, block registry validation, and docs manifest validation passed. Required artifact generators completed without drift.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 26, 2026 9:55pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/api/contracts/hotspots.ts
Comment thread apps/sim/lib/mothership/agent-cli/engines/deps.ts Outdated
@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds input size and count limits to code execution and chat contexts.

The PR appears safe to merge; no new actionable regression was established.

Summary

The PR bounds Function execution inputs and references, chat messages and contexts, and workflow dependency reports. It also replaces repeated reference processing with cached or indexed passes.

Reviews (2) · Last reviewed commit: "fix(execution): preserve compatibility a..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/function-execution/execute-request.ts
@waleedlatif1
waleedlatif1 merged commit 954012c into staging Sep 26, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/bound-reference-processing branch September 26, 2026 22:09

This branch was previously deployed

1 inactive deployment
Preview — cb688e90 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant