fix(desktop): require folder permission for native file tools by waleedlatif1 · Pull Request #8345 · simstudioai/sim

waleedlatif1 · 2026-09-26T21:48:58Z

Summary

Ask once for folder access before native file reads and imports, and remember the approval across chats and app restarts using the existing encrypted grant store.
Reuse folders already approved for VFS access; add File → Folder Access controls to add or forget folders. Approved reads continue while unrelated permission prompts are open.
Revalidate pending calls and enforce canonical paths, folder identity, and revocation. Enumerate directories through a verified descriptor to prevent path-swap races. Sign-out and server changes clear remembered access.

Type of Change

Bug fix

Testing

Desktop suite: 870 tests passing; Sim app, desktop, and desktop-bridge type-checks passing.
Electron E2E covers consent, recursive access across chats, import reuse, restart persistence, revocation, sign-out, cancellation during consent and after file opening, revoked VFS reads, and symlink or replaced-folder denial. A deterministic ancestor-swap test reproduces the old directory-name leak and passes with descriptor-based enumeration. Screenshot artifact supports DESKTOP_LOCAL_FILES_REPORT_PATH.
Verified regression failures by removing pending-call, persistence, revocation, path and folder-identity guards independently. Existing encrypted folder approvals migrate without prompting again.
Lint, block-registry check, all 51 repository audits, and docs-manifest check passing.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-26T21:49:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 26, 2026 10:59pm UTC

cubic-dev-ai

All reported issues were addressed across 8 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-26T21:53:23Z

Confidence Score: 5/5

[High risk] Adds native file system access control with new permission checks.

The PR appears safe to merge; no new actionable issue or outstanding previous finding remains.

Summary

The PR requires remembered folder consent for native file reads and imports, shares grants with VFS access, and adds File → Folder Access controls.

Pending calls, folder identity, and revocation are rechecked during access.
Directory listings use a verified descriptor and reject a directory replaced during enumeration.
New tests cover consent, persistence, cancellation, revocation, and path replacement.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Call[Pending native file call] --> Check[Server authorization]
  Check --> Grant{Approved folder?}
  Grant -->|No| Consent[Native consent dialog]
  Consent --> Store[Encrypted grant store]
  Grant -->|Yes| Verify[Revalidate call and folder]
  Store --> Verify
  Verify --> Open[Open and verify descriptor]
  Open --> Result[Bounded read or import]

_{Reviews (5) · Last reviewed commit: "fix(desktop): reject replaced directory ..."}

waleedlatif1 · 2026-09-26T22:08:01Z

@greptile

waleedlatif1 · 2026-09-26T22:08:03Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:08:08Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 13 files

_{Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:31:52Z

@greptile

waleedlatif1 · 2026-09-26T22:31:54Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:31:59Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 15 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:52:04Z

@greptile

waleedlatif1 · 2026-09-26T22:52:05Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:52:10Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 20 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-26T22:59:20Z

@greptile

waleedlatif1 · 2026-09-26T22:59:21Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T22:59:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 20 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

vercel Bot temporarily deployed to Preview September 26, 2026 21:49 Inactive

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-file-permissions.ts Outdated

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-file-permissions.ts Outdated

Comment thread apps/desktop/src/main/local-file-permissions.ts Outdated

Comment thread apps/desktop/e2e/local-files.spec.ts Outdated

waleedlatif1 force-pushed the codex/desktop-local-file-consent branch from d43d45a to 6ca8a97 Compare September 26, 2026 22:07

vercel Bot temporarily deployed to Preview September 26, 2026 22:07 Inactive

waleedlatif1 changed the title ~~fix(desktop): ask before accessing local files~~ fix(desktop): require folder permission for native file tools Sep 26, 2026

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

waleedlatif1 added 3 commits September 26, 2026 15:28

fix(desktop): ask before accessing local files

18bba95

fix(desktop): remember folder permissions across chats

9965e85

fix(desktop): cancel pending file consent and recheck access

b5ae75a

waleedlatif1 force-pushed the codex/desktop-local-file-consent branch from 6ca8a97 to b5ae75a Compare September 26, 2026 22:31

vercel Bot temporarily deployed to Preview September 26, 2026 22:31 Inactive

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-files.ts Outdated

Comment thread apps/desktop/src/main/ipc.ts

fix(desktop): enumerate approved directory descriptors

94a8dad

waleedlatif1 requested a review from a team as a code owner September 26, 2026 22:51

vercel Bot deployed to Preview September 26, 2026 22:53 View deployment

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/native/directory.cc

Comment thread apps/desktop/src/main/local-files.ts

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/desktop/src/main/local-files.ts

fix(desktop): reject replaced directory listings

ce6f05b

vercel Bot temporarily deployed to Preview September 26, 2026 22:59 Inactive

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Conversation

waleedlatif1 commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

waleedlatif1 commented Sep 26, 2026 •

edited

Loading

vercel Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading