fix(desktop): wait for native update staging and verify installation

[waleedlatif1]

Summary

• Wait for native Squirrel staging before offering restart, including when a newer release replaces an already staged update. Retain an older staged build only while its native feed is still valid, and let failed native staging retry safely. Handle background check failures independently of native failures so they cannot cancel a confirmed restart.
• Record the staged version atomically and compare it with the version running on the next launch, so an interrupted installation is distinguishable from a completed upgrade.
• Exercise real Electron and MacUpdater downloads, replacement failures, cached retries, and installation checkpoints. This follows Electron's native update lifecycle.

Type of Change

• Bug fix

Testing

• 870 desktop tests; desktop type check and build.
• Real Electron/MacUpdater integration test, demonstrated failing against the original updater. JSON checks and HTTP request evidence are written to DESKTOP_UPDATER_REPORT_PATH or Playwright test results.
• Native verification and signed bundle replacement are simulated in the integration fixture; a signed release upgrade remains release validation.
• Repository lint, all 51 audits, block-registry checks, and docs-manifest check.
• Full local Electron run: 56 passed, 3 packaged-only skips, and 4 browser/password-picker failures. All 4 passed on focused reruns; the unpackaged shell exits updater initialization before the changed logic.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 26, 2026 10:20pm UTC

[cubic-dev-ai]

No issues found across 7 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[High risk] Changes how the desktop app stages and verifies software updates.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR waits for native Squirrel staging before offering a restart, tracks staged versions across launches, and adds unit and real-Electron coverage for replacement, retry, and installation outcomes.

• Since the previous review, error handling separates request failures from native failures, and the integration test explicitly requests its replacement check.
• Both previous Greptile threads are resolved; neither finding remains outstanding.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Validated update] --> B[Download archive]
  B --> C[Native staging]
  C -->|Confirmed| D[Ready to restart]
  C -->|Native failure| E[Error and retry]
  D --> F[Install on restart or quit]
  F --> G[Compare checkpoint on next launch]

Loading

_{Reviews (2) · Last reviewed commit: "fix(desktop): distinguish refresh failur..."}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 7 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}