Skip to content

fix(chat): use hostname brand icons for inline sources - #8350

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/inline-link-host-icons
Sep 27, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/inline-link-host-icons

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use existing SVG brand icons for recognized source hostnames when connector metadata is absent, including Slack workspace links.
  • Preserve document and connector icon precedence, destination labels, and favicon fallbacks for unknown hosts.

Type of Change

  • Bug fix

Testing

40 focused tests passed across source icons, inline links, citations and preview fetching. The hostname regression failed before the fix, and removing the suffix boundary independently fails its negative control. Browser QA covered 17 icon cases, inline previews, unchanged sizing and both themes. All nine cleanup passes, 26-workspace type-check and lint, 51 audits, generators, block-registry audit and docs-manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 27, 2026 1:33am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes which brand icons display for message sources.

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR adds local brand icons for recognized source hostnames when connector metadata is absent, then extends that behavior to www. variants of GitHub, GitLab, and Notion. The added tests cover recognized hosts and Slack lookalike URLs. The previously reported test-coverage thread was resolved.

Reviews (2) · Last reviewed commit: "fix(chat): recognize www aliases in sour..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit bccc722 into staging Sep 27, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/inline-link-host-icons branch September 27, 2026 01:47

This branch was previously deployed

1 inactive deployment
Preview — 62827b08 Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant