Skip to content

feat(chat): add shared find menu - #8351

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/chat-find
Sep 27, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/chat-find

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Add Cmd/Ctrl-F to chat using the shared find bar and existing highlight colors.
  • Navigate matching text across virtualized messages, restore composer focus, and keep streaming from pulling the selected match out of view.
  • Reuse displayed mention text and exclude hidden metadata from search.

Type of Change

  • New feature

Testing

  • Cleanup review across React, state, styling, query, URL state, comments, and test-audit passes.
  • 57 focused tests covering chat text parsing, message segmentation, copyable Markdown, and neighboring chat rendering logic.
  • App type-check, repository lint, all 51 audits, block-registry check, and docs-manifest check.
  • Browser verification with 120 virtualized messages: keyboard navigation and wrapping, Markdown and mention highlights, line breaks, code, no results, capped results, focus restoration, chat switches, and streaming.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 27, 2026 2:15am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 13 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/workspace/[workspaceId]/components/find-bar/use-find-shortcut.ts Outdated
@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds find-in-chat search across message content.

The PR appears safe to merge; no new actionable issue was established.

Summary

The PR adds a shared find bar to chat, with search across virtualized messages, match highlighting and navigation, focus restoration, and scrolling coordination during streaming. The change since the previous review defers send scrolling while find is open so it can be retried when find closes.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Open chat find] --> B[Search displayed message text]
  B --> C[Select and reveal match]
  C --> D[Pause automatic scrolling]
  D --> E[Close find]
  E --> F[Restore focus and retry pending send scroll]
Loading

Reviews (3) · Last reviewed commit: "fix(chat): resume pending send scroll af..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2aed9b5 into staging Sep 27, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/chat-find branch September 27, 2026 02:27

This branch was previously deployed

1 inactive deployment
Preview — f904f050 Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant