Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
| hunter_email_verifier: hunterEmailVerifierTool, | ||
| hunter_companies_find: hunterCompaniesFindTool, | ||
| hunter_email_count: hunterEmailCountTool, | ||
| presend_email_verify: presendEmailVerifyTool, |
There was a problem hiding this comment.
Tool missing from catalog Registering
presend_email_verify here does not add it to the generated tool IDs that the catalog uses. Users therefore cannot discover or select the new tool, and the metadata synchronization check will fail. Regenerate and commit the tool metadata alongside this registration.
| }, | ||
| reason: { | ||
| type: 'string', | ||
| description: 'Explanation when the address is invalid, otherwise null', |
There was a problem hiding this comment.
Reason description contradicts output The description says
reason is null for a valid address, but the response mapping converts null to an empty string. Consumers relying on the documented value may handle valid results incorrectly; describe the value the tool actually returns.
| description: 'Explanation when the address is invalid, otherwise null', | |
| description: 'Explanation when the address is invalid, otherwise an empty string', |
| // Common types for Presend tools | ||
| import type { ToolResponse } from '@/tools/types' | ||
|
|
||
| // Email Verify tool types |
There was a problem hiding this comment.
Declaration comments use inline syntax
// Email Verify tool types is a category comment before an exported declaration, and the same pattern appears at the top of this file. The repository requires TSDoc for documentation and reserves // for terse, non-obvious explanations or enforced annotations. This requirement must be satisfied before merging.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Disclosure: I maintain Presend. Thanks for picking this up, @Zoymusk. The field mapping matches the live response. One heads-up from our side, prompted by this PR: until today, With Also worth knowing: the endpoint allows 30 requests per minute per client IP. Since Sim calls it server-side, all workspaces share your egress IPs, so heavy use will hit 429s. Your executor checks |
|
@Zoymusk is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
|
Pushed a fix commit addressing the review feedback:
|
Adds
presend_email_verify, a free, no-signup, no-key email verification tool, following the existing tool file conventions (seetools/hunter/email_verifier.ts).Closes #8034
Scope: matches what @presendapp proposed in the issue — just the verification tool (syntax, MX record, disposable-domain, role-account checks), not Hunter's finder/discovery/company-lookup functionality.
Verified against the live endpoint (
GET /api/email-verify?email=) — response is flat JSON with snake_case keys (syntax_valid,has_mx,mx_count,role_account, etc.), mapped to camelCase intransformResponse.Testing:
bun install+ TypeScript checks pass with no errors in the new files.