Skip to content

fix(search): validate Notion search terms before dispatch - #8358

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/notion-query-validation
Sep 28, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/notion-query-validation

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Reject empty Notion native queries before dispatch, including date-bounded and sorted requests.
  • Validate Notion-only live listings and return actionable argument errors while preserving supported date-only and mixed-provider searches.
  • Regenerate the shared worker contract and search guidance.

Companion: https://github.com/simstudioai/mothership/pull/544

Type of Change

  • Bug fix

Testing

  • 252 provider and retrieval tests passed; 51 focused tests passed again after restoring each mutation control.
  • Three independently removed guards made their named regression tests fail; the original worker validator also reproduced the bug before regeneration.
  • Type checks across 26 workspaces, lint, all 51 audits, block registry, docs manifest and contract-generation checks passed.
  • Validation uses synthetic fixtures; no fresh external-account or live-model acceptance is claimed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 28, 2026 1:06am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds validation for Notion search queries.

The PR appears safe to merge; no actionable regression was established.

Summary

The PR adds explicit validation for empty Notion native queries and Notion-only live listings, surfaces a more actionable argument error, and updates generated contracts and search guidance.

Reviews (1) · Last reviewed commit: "fix(search): validate Notion search term..."

@github-actions github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Sep 28, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

  • ❌ simstudioai/mothership#544 — OPEN, not merged (targets staging) — fix(search): reject empty Notion queries before dispatch

@waleedlatif1
waleedlatif1 merged commit bf2594c into staging Sep 28, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/notion-query-validation branch September 28, 2026 02:04

This branch was previously deployed

1 inactive deployment
Preview — 410b4f3c Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant