fix(chat): keep find stable across footnotes and pending chats, and match mention chips next to punctuation - #8361
Conversation
…atch mention chips next to punctuation
…he integration matcher mock
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
[data-footnote-ref]/[data-footnotes]are excluded from the DOM walk. The chat's link renderer now forwardsdata-footnote-refso the marker can be excludedslash_commandcontexts render with the/prefix@Workflow,and back-to-back repeats (@A @A) now match, while@Workflow-2still doesn't match@Workflow@reportvs@report.pdf,WorkflowvsWorkflow 2)@/blocks/integration-matchertest mock moves to one central@sim/testingmock used by all four suitesType of Change
Testing
use-chat-find.test.tsxrenders realChatContentmarkup: find survives undefined → id but resets on a chat switch, and a footnoted message's match count equals its highlighted ranges. Each fails with its guard revertedutils.test.ts: punctuation, repeats, slash commands, the prefix boundary, and longest-overlap cases. The behavior cases fail on stagingcheck:auditspassChecklist