fix(databricks): send workspace tokens only to Databricks workspace hosts - #8362
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 16 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostwithout checking it was a Databricks workspace, so the workspace token went to whatever host was entered. The executor's DNS and pinned-IP guard already blocks private targets; this closes the restdatabricksUrl, which runs the samevalidateDatabricksWorkspaceHostallowlist the Databricks KB connector uses and builds from the sanitized https origin. Request paths, methods, headers, and bodies are unchanged.cloud.databricks.mil(AWS GovCloud DoD workspaces) and.databricks.com(Databricks custom workspace URLs), so no workspace host that worked before is refused.http://hosts keep being upgraded to httpsvalidateVendorHostedUrlstrips a single trailing FQDN dot before the suffix check and builds the URL from the dotless host. A trailing-dot host now connects: Bun's TLS check rejects the dotted name. This applies to Databricks, ServiceNow, and Workday; hosts without a trailing dot are unchangedType of Change
Testing
tools/databricks/databricks.test.ts: foreign and lookalike hosts are refused by all 26 tools before any request. The accepted host forms (bare, https, http, trailing slash, whitespace, AWS, GovCloud, DoD, GCP, Azure, Azure Gov, Azure China, a custom URL) build the same URLs the old tools built, and trailing-dot hosts build a dotless URL. The refusal,.mil, custom-URL, and trailing-dot cases fail on staginginput-validationsuites (263 tests), type-check, lint, andcheck:auditspassChecklist