Skip to content

test(knowledge): accept either ordered index in the scale window check and bound discussion case text - #8363

Merged
waleedlatif1 merged 2 commits into
stagingfrom
chore/review-followup-tests
Sep 28, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
chore/review-followup-tests

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • scale.integration.ts: the reconciliation window-scan plan may walk the v2 index or the primary key (the fixture's single connector is nearly the whole table). The check now requires every index in the plan to be one of those two and at least one to be present, instead of v2 only, so it still rejects a plan that reads the connector through another index and sorts
  • github.ts exports exceedsGitHubTextLimit (the same count and 256-character boundary as the inline check it replaces in searchGitHub), and scripts/test-search-discussions-live.ts rejects over-limit case queries while parsing, before any oracle request
  • Responds to review threads on v0.9.4: db contention fixes, databricks genie, snowflake cortex, additional search connectors #8356

Type of Change

  • Other: test and script hygiene

Testing

  • An oversized case fails at parse time with no request made
  • sim-search live suites (218 tests) and type-check pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 28, 2026 1:46am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Relaxes a database query test assertion and adds a validation helper.

The PR appears safe to merge; no issue caused by these changes was identified.

Summary

The PR permits either of two ordered indexes in the knowledge scale-plan check and reuses GitHub’s search-text limit check to validate live discussion cases before requests.

Reviews (1) · Last reviewed commit: "chore: document the GitHub text-limit he..."

@waleedlatif1
waleedlatif1 merged commit a763b4a into staging Sep 28, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/review-followup-tests branch September 28, 2026 02:07

This branch was previously deployed

1 inactive deployment
Preview — ec3efcb5 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant