Skip to content

feat(search): add HubSpot CRM member search - #8387

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/hubspot-live-search
Sep 28, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/hubspot-live-search

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add read-only HubSpot member search for contacts, companies, deals, and tickets, with query-bound continuation, stable listing cutoffs, date filtering, verified record citations, and CRM property reads.
  • Use a deployment-owned MCP OAuth app so members only sign in. Bind authorization attempts and personal grants to the app configuration, and require reconnect after registration changes.
  • Reuse integration icon tiles in Credential Groups and show HubSpot only when connection setup is available. Document supported queries and limitations.

Companion worker contract: https://github.com/simstudioai/mothership/pull/547.

Type of Change

  • New feature

Testing

  • Full workspace tests: 19 successful tasks, including 34,502 passing app tests and 25 existing skips. Full worker checks: 1,164 passing tests and eight opt-in skips.
  • Seven real PostgreSQL/Redis OAuth integration cases and eight independent OAuth guard controls. Nine cursor regressions failed before their respective fixes; five independent cursor guard-removal controls also failed as intended.
  • Eleven live read-only HubSpot cases plus seven fresh checks through the running Sim HTTP boundary, including continuation, account/query binding, multi-kind fanout, and invalid request rejection.
  • Six fresh assistant questions independently checked for records, citations, reads, date bounds, ordering, no-match behavior, and unsupported ownership filtering. Zero tool errors; 6.6–23.4 seconds per answer while local checks ran concurrently. Contacts/companies have positive fixtures; deals/tickets have empty-collection coverage.
  • Type checks across 26 workspaces; lint, all 51 audits, generators, exact cross-repository contract sync, registry and docs checks. UI cleanup and visual inspection of provider tiles and source setup passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 28, 2026 10:08pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 51 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.ts Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/components/resource-tile/resource-tile.tsx Outdated
Comment thread apps/sim/lib/sim-search/live/hubspot-mcp.ts
Comment thread apps/sim/lib/sim-search/live/hubspot-mcp.ts
@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds HubSpot CRM member search integration.

The PR appears safe to merge; no outstanding or new actionable finding was established.

Summary

This PR adds read-only HubSpot CRM member search, deployment-owned MCP OAuth setup, connection-availability controls, and documentation.

  • Search supports four CRM record kinds, verified record reads, date filtering, and continuation bound to the search context.
  • Organization and member settings expose HubSpot setup according to connector availability.
Diagram
sequenceDiagram
  participant Member
  participant Sim
  participant HubSpot
  Member->>Sim: Connect HubSpot account
  Sim->>HubSpot: OAuth using deployment-owned MCP app
  HubSpot-->>Sim: Personal grant
  Member->>Sim: Search CRM records
  Sim->>HubSpot: Read-only search with member grant
  HubSpot-->>Sim: Records and pagination
  Sim-->>Member: Verified results and bound continuation
Loading

Reviews (2) · Last reviewed commit: "fix(search): bind HubSpot continuation a..."

Comment thread apps/sim/lib/sim-search/live/hubspot-mcp.ts
@waleedlatif1
waleedlatif1 force-pushed the codex/hubspot-live-search branch from 4841138 to 2a04ef2 Compare September 28, 2026 22:06
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 56 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a2af0e9 into staging Sep 28, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/hubspot-live-search branch September 28, 2026 22:27

This branch was successfully deployed

1 active deployment
Preview — 2a04ef27 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant