Skip to content

fix(search): preserve Gmail reads when replies disappear - #8388

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/gmail-missing-reply
Sep 28, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/gmail-missing-reply

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve the requested Gmail message and readable replies when an optional reply disappears after thread discovery, and mark conversation coverage incomplete.
  • Handle only the missing reply's 404; retain authorization checks and propagate credential, quota, server, and cancellation failures.

Type of Change

  • Bug fix

Testing

  • Google content HTTP acceptance: 54 checks passed; missing-reply cases fail before each fix for both metadata verification and full-message reads. Synthetic loopback fixtures exercise the production reader and transport, not a connected Google account.
  • Three independent mutation controls reject a broad error catch, missing coverage warning, and stopping before remaining readable replies.
  • Live-provider regression suite: 240 tests passed across 30 files.
  • App type-check, lint, 51 audits, block registry check, artifact generators, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 28, 2026 9:03pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds error handling to Gmail message fetch.

The PR appears safe to merge; the previously reported verification-time missing-reply failure is fixed.

Summary

The PR preserves a requested Gmail message and readable replies when another reply disappears, marking conversation coverage incomplete. The follow-up change also handles a 404 during per-reply verification and adds HTTP regression cases for metadata and full-message failures.

Reviews (2) · Last reviewed commit: "fix(search): handle replies missing duri..."

Comment thread apps/sim/lib/sim-search/live/google.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit d12e31c into staging Sep 28, 2026
23 of 24 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/gmail-missing-reply branch September 28, 2026 21:10

This branch was previously deployed

1 inactive deployment
Preview — 09ec7ca2 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant