Skip to content

refactor: remove dead code and enforce code quality gates - #8395

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/codebase-quality
Sep 29, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/codebase-quality

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove 24 orphan app modules, obsolete credential hooks/operations, 19 provider stream forwarding helpers and seven forced-tool helpers.
  • Share the four Chat Completions execution loops while preserving provider-specific reasoning, schemas, usage, billing identity, abort and streaming behavior.
  • Add a pinned Knip audit, parse package-boundary imports with TypeScript, collect all script suites through one runner, and fix root lint coverage/cache inputs.
  • Bind script-test collection to the actual runner command so a no-op, alternate configuration or filename filter cannot falsely pass the guard.

Type of Change

  • Bug fix
  • Other: dead-code removal, provider consolidation and quality enforcement

Testing

  • Repeated full local test run: 36,829 passed, 25 existing skips; includes 3,269 app test files and 29 root script suites.
  • 52/52 audits and 26/26 workspace lint/type checks passed. Changed guard files also pass strict TypeScript checks.
  • Real CLI regression cases failed before the fixes and passed afterward. Negative controls verified dead-code/dependency detection, lint-cache invalidation and provider request preparation.
  • Independent reviews traced deleted consumers, compared provider behavior and checked the quality gates; the runner-command finding is fixed and re-reviewed.
  • Fresh GitHub CI on the final commit passed app build, full tests, both PostgreSQL integration paths, real HTTP SCIM/administration checks, desktop E2E/package smoke and Helm installation. Cubic and Greptile reported no issues across all 102 changed files.

Knip includes test reachability and documented dynamic entrypoints. Live hosted-provider suites were not invoked.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 29, 2026 1:06am UTC

Request Review

@waleedlatif1
waleedlatif1 marked this pull request as ready for review September 29, 2026 01:04
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner September 29, 2026 01:04
@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Removes unused code across multiple feature areas.

The PR appears safe to merge; no actionable issue caused by the changes was established.

Summary

The PR removes unused modules and forwarding helpers while consolidating four Chat Completions provider loops.

  • Adds a pinned dead-code audit and TypeScript-based package-boundary check.
  • Consolidates root script-test collection and expands lint and cache inputs.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Baseten / Fireworks / OpenRouter / Together] --> B[Shared Chat Completions execution]
  B --> C[Provider-specific response format and model identity]
  B --> D[Tool loop and conversation accounting]
  B --> E[Streaming or settled response]
Loading

Reviews (1) · Last reviewed commit: "fix(ci): bind script coverage to the exe..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 102 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 07c3ffe into staging Sep 29, 2026
41 of 42 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/codebase-quality branch September 29, 2026 01:17

This branch was successfully deployed

1 active deployment
Preview — e6fdd5a8 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant