You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a warning-only design diff check to the existing Test and Build workflow. Product findings become file/line warnings; an inspection failure fails the check.
Derive design facts from EMCN source, globals.css, and the central packages/emcn/src/design-ownership.json decisions for each inspected revision. The full scanner publishes the EMCN inventory and detected Extras in scan.json.
Add a separate, local-only Design Studio under tools/design-studio. An explicit refresh builds the catalog and previews; the Studio is absent from Sim's deployed routes.
Keep landing, docs, Monaco presentation, provider branding, and intentional block palettes outside product checks. Browser desktop screens remain in scope.
This is a replacement draft for #8313, rebased by merging current staging into a new branch. It changes tooling and design guidance, not product rendering. It will not be merged automatically.
Use
bun run check:design --base origin/staging --working-tree
bun run check:design --base origin/staging --head HEAD
bun run design:scan --repo . --working-tree --output /tmp/sim-design-scan
bun run studio:refresh
bun run studio:dev
The diff command includes staged, unstaged, and nonignored new product files. CI compares immutable revisions. Findings are advisory; failed inspection is an error. A full scan and Studio refresh are deliberate local commands, and their reports and captures stay outside the repository. Every detected Extra enters Studio without an approval gate. A renderable indicative sample is labeled separately from a live source preview; fixture gaps remain visible.
Verification on merged staging
bun run test:scripts: 821 tests across 43 files passed.
bun run check:audits: all 52 audits passed, including the new dead-code audit.
Design and Studio type checks, root lint and format checks, and frozen lockfile install passed.
Immutable design diff against origin/staging: 23 central system-change findings, zero product findings, 805 unchecked diagnostics, and zero inspection failures. The 23 findings reflect the introduction of ownership and contract metadata; findings are warning-only.
Current full scan: 2,308 styling findings, 2,251 control/source candidates, 2,887 styling diagnostics, and zero inspection failures. Studio refresh publishes 759 EMCN export/variant entries and all 2,308 detected Extras. Its 237 fixture gaps remain visible, so the refresh exits 1 for incomplete preview coverage.
The merge includes staging's expanded script test discovery and dead-code gate. Studio's direct dependencies are declared, and its local Next cache is excluded from that audit.
Coverage limits
New public EMCN exports and finite variants are discovered from source. Exports needing providers or required props may need a Studio fixture adapter. Unsupported static flows remain visible as unchecked; a failed inspection cannot look like a clean result. Indicative Extra previews show detected styling but do not assert a source-backed rendering. See scripts/design-conformance/README.md and scripts/design-studio/README.md.
[High risk] Adds design conformance checking and local Studio tooling.
The PR appears safe to merge based on this review.
Summary
The PR adds an advisory design-conformance check to CI and a separate local Design Studio. Since the previous review, it changed the Studio import to the established alias and added a fixture-edit freshness regression test. No new actionable issue was identified.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Source[EMCN and product source] --> Check[Design diff check]
Check --> Warnings[CI warnings and report]
Source --> Scan[Local full scan]
Scan --> Refresh[Studio refresh]
Refresh --> Catalog[Local Studio catalog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Summary
globals.css, and the centralpackages/emcn/src/design-ownership.jsondecisions for each inspected revision. The full scanner publishes the EMCN inventory and detected Extras inscan.json.tools/design-studio. An explicit refresh builds the catalog and previews; the Studio is absent from Sim's deployed routes.This is a replacement draft for #8313, rebased by merging current
staginginto a new branch. It changes tooling and design guidance, not product rendering. It will not be merged automatically.Use
bun run check:design --base origin/staging --working-tree bun run check:design --base origin/staging --head HEAD bun run design:scan --repo . --working-tree --output /tmp/sim-design-scan bun run studio:refresh bun run studio:devThe diff command includes staged, unstaged, and nonignored new product files. CI compares immutable revisions. Findings are advisory; failed inspection is an error. A full scan and Studio refresh are deliberate local commands, and their reports and captures stay outside the repository. Every detected Extra enters Studio without an approval gate. A renderable indicative sample is labeled separately from a live source preview; fixture gaps remain visible.
Verification on merged
stagingbun run test:scripts: 821 tests across 43 files passed.bun run check:audits: all 52 audits passed, including the new dead-code audit.origin/staging: 23 central system-change findings, zero product findings, 805 unchecked diagnostics, and zero inspection failures. The 23 findings reflect the introduction of ownership and contract metadata; findings are warning-only.staging's expanded script test discovery and dead-code gate. Studio's direct dependencies are declared, and its local Next cache is excluded from that audit.Coverage limits
New public EMCN exports and finite variants are discovered from source. Exports needing providers or required props may need a Studio fixture adapter. Unsupported static flows remain visible as
unchecked; a failed inspection cannot look like a clean result. Indicative Extra previews show detected styling but do not assert a source-backed rendering. Seescripts/design-conformance/README.mdandscripts/design-studio/README.md.