Skip to content

fix(ui): clean up stale workflow state and provider policy handling - #8400

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/codebase-quality-react-pass
Sep 29, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/codebase-quality-react-pass

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the unused mention-data hook, folder helpers and legacy constants while preserving the live menu behavior and graph audit coverage.
  • Keep chat prompt-history navigation stable during streamed replies and refresh workflow preview labels after loading or renaming.
  • Keep provider permission controls unavailable until policy loads successfully, and surface failed reads with retry.

Type of Change

  • Bug fix

Testing

  • 36,837 tests passed with 25 existing skips before the staging sync; reran affected tests and checks after rebasing.
  • Added six behavioral regressions for chat navigation and provider-policy failure/retry; reproduced the original failures and checked each relevant safeguard independently. Removed the two preview text-assertion unit tests to follow the repository's testing policy.
  • Chromium component checks reproduced the chat/preview failures before the fixes and passed afterward. Execution, auth, catalog and terminal boundaries use fixtures; this is not a deployed-app E2E run.
  • Lint, type checks and all 52 repository audits passed. Production code is 620 lines smaller overall.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 29, 2026 2:52am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/testing/src/mocks/terminal-console.mock.ts
@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Refactors chat state management and cleans up unused code.

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR removes unused mention-menu code and updates chat history navigation, preview label refresh, and provider-policy loading.

  • Provider controls remain unavailable while policy loading fails, with a retry path.
  • The previously flagged preview text-assertion tests have been removed.

Reviews (2) · Last reviewed commit: "chore(tests): address cleanup review fin..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 52cc796 into staging Sep 29, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/codebase-quality-react-pass branch September 29, 2026 02:59

This branch was previously deployed

1 inactive deployment
Preview — 805e2225 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant