Skip to content

fix(knowledge): shrink the member lifecycle budget tests so they stop timing out in CI - #8404

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/member-lifecycle-test-flake
Sep 29, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/member-lifecycle-test-flake

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The two budget-boundary tests in member-document-lifecycle.integration.ts sized their fixtures off the production reconcile budget (20 pages × 500), so each seeded 10k+ documents and intermittently hit the 30s test timeout on CI Postgres
  • Mock MEMBER_TOMBSTONE_RECONCILE_PAGES_PER_RUN to 3 for this file only; the tests derive their sizes from the constant, so they still cover the cursor save/resume and multi-run pass semantics with ~2k documents
  • Three pages (not two) keeps "walks multiple batches" finishing its ~1.1k stale documents in one run

Type of Change

  • Bug fix (flaky test)

Testing

  • bun run test:integration member-document-lifecycle: 3/3 green, file runtime 11.5–16s → ~3.1s locally
  • Mutant that ignores the page budget in reconcileUnobservedPages still fails both budget tests
  • bun run check:test-patterns, bun run lint, bun run check:audits (52 audits), docs-manifest:check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 29, 2026 4:51am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Test file mocks a production configuration constant.

The PR appears safe to merge; the smaller test budget preserves the intended boundary coverage.

Summary

The PR limits the reconciliation page budget within one integration test file, reducing fixture sizes while retaining the budget-boundary scenarios.

  • Production reconciliation limits are unchanged.
  • No actionable issue caused by the change was identified.

Reviews (1) · Last reviewed commit: "fix(knowledge): shrink the member lifecy..."

@waleedlatif1
waleedlatif1 merged commit 4f6c2d3 into staging Sep 29, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/member-lifecycle-test-flake branch September 29, 2026 05:12

This branch was previously deployed

1 inactive deployment
Preview — 7d1f1485 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant