improvement(execution): cut the time between a workflow trigger and its first block by waleedlatif1 · Pull Request #8434 · simstudioai/sim

waleedlatif1 · 2026-09-29T21:21:57Z

Summary

Measured where time goes between a trigger (webhook, schedule, API) and the first block running: preprocessing itself is fast; the cost is ~40 sequential DB round trips plus shipping the full deployed state (hundreds of KB for large workflows) up and back several times per run
Schedule dispatch: TriggerDevJobQueue.getJob called runs.retrieve with caller-chosen ids (schedule_…, workflow-execution:…), which Trigger.dev takes ~10 s to 404 (vs <1 s for a real run id). Every schedule tick stalled ~9.6 s on this before enqueueing anything. Only run_ ids are retrieved directly now; others go straight to the jobId: tag lookup
Log start: snapshot id resolved by hash (cached per process once a log row references it) and the log inserted with ON CONFLICT (execution_id) DO NOTHING — replaces select-existing-log + full-state upsert RETURNING * + insert. Orphan-cleanup race handled by re-resolving on FK violation. Child workflow snapshots use the same id-only resolution
Preprocessing: payer attribution starts alongside the workflow read when the workspace is known; ban/usage/subscription gate reads start as soon as actor + payer are known and are applied in the same fixed precedence; the actor subscription is only read when rate limiting runs (or the caller asks — table cells)
Execution core: env + PII policy reads start before the custom-block overlay, custom blocks and outbound context load in parallel, and the webhook job's already-loaded environment is reused instead of loaded/decrypted twice
Webhooks: lookups compute trigger-block deployment from the active version they already join (no second query, no full-state fetch); webhook job starts its env load right after preprocessing
Fewer round trips in shared lookups: getHighestPrioritySubscription (3 → 1 stage), custom-block rows (rows first, entitlement only when rows exist), env suspension check runs alongside access/env reads
Versioned deployment loads serve the materialized-state cache before querying (entries now bound to their workflow)

Results

Opt-in harness driving the real webhook route in-process (inline backend, real Postgres/Redis, 1 ms injected DB latency, ~390 KB workflow, billing on), baseline and branch alternated:

delivery → first block: p50 194–235 ms → 85–108 ms, p90 241–266 → 116–128 ms
job start → first block: 132–160 ms → 48–60 ms
route response: 58–67 ms → 32–42 ms
no injected latency: 49 → 24 ms p50

Type of Change

Improvement / performance

Testing

New real-Postgres integration tests: start-execution (dedup, idempotent start, cleanup-deleted snapshot recovery, concurrent starts), execution-environment (owner/actor identities, suspension, lapsed access), trigger-block-deployment (lookup flag vs standalone check, cache bound to workflow), workspace-rows (entitlement), plan (tier priority, org-over-personal tie-break); key guards shown red by mutation
trigger-dev.test.ts regression for caller-chosen job ids (fails on old code); preprocessing precedence tests for the early gate reads
Full apps/sim unit suite (34,580 passed), full bun run test:integration (1,113 + 106 passed), bun run type-check, bun run lint, bun run check:audits (52), docs-manifest:check
Independent review of the diff; findings addressed (snapshot cache only remembers referenced ids, FK retry scoped to the insert, comment fixes)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ts first block - Trigger.dev getJob only retrieves real run ids; caller-chosen ids (schedule_…, workflow-execution:…) go straight to the tag lookup instead of a ~10 s 404 - Execution-log start resolves the snapshot id (cached once referenced) and inserts with ON CONFLICT instead of select + full-state upsert RETURNING * + insert - Preprocessing starts payer attribution and the ban/usage/subscription gate reads as soon as their inputs are known; subscription is only read when needed - Execution core prefetches env + PII policy alongside custom blocks and reuses the webhook job's already-loaded environment - Webhook lookups answer trigger-block deployment from the join they already do; versioned deployment loads serve the materialized cache first - getHighestPrioritySubscription, custom-block rows, and env suspension lookups drop sequential round trips

vercel · 2026-09-29T21:22:00Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 29, 2026 10:12pm UTC

cubic-dev-ai

All reported issues were addressed across 29 files

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-29T21:28:47Z

Confidence Score: 5/5

[High risk] Refactors workflow execution environment loading and snapshot resolution.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR reduces work between a trigger and its first workflow block.

Caller-chosen Trigger.dev job IDs use tag lookup instead of a slow failed run-ID retrieval.
Execution admission, environment, and policy reads begin earlier; webhook jobs reuse their resolved environment.
Snapshot and deployment-state caching reduce repeated database reads and transfers, with integration coverage for key persistence and access paths.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  T[Trigger] --> A[Admission reads]
  A --> Q[Queued or direct execution]
  Q --> E[Environment and deployment state]
  E --> L[Idempotent log and snapshot]
  L --> B[First block]

_{Reviews (4) · Last reviewed commit: "improvement(environment): reuse the acto..."}

…y's access read out of the run, tidy tests

waleedlatif1 · 2026-09-29T21:40:44Z

@greptile

waleedlatif1 · 2026-09-29T21:40:45Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-29T21:40:51Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 29 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

…shot identity, explicit suspension paths

waleedlatif1 · 2026-09-29T21:58:30Z

@greptile

waleedlatif1 · 2026-09-29T21:58:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-29T21:58:38Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 29 files

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Fix all with cubic | Re-trigger cubic}

…holding a suspended identity

waleedlatif1 · 2026-09-29T22:12:59Z

@greptile

waleedlatif1 · 2026-09-29T22:13:00Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-29T22:13:06Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 29 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

vercel Bot temporarily deployed to Preview September 29, 2026 21:22 Inactive

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread apps/sim/lib/logs/execution/start-execution.integration.ts Outdated

Comment thread apps/sim/lib/environment/utils.ts Outdated

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread apps/sim/lib/core/async-jobs/backends/trigger-dev.test.ts Outdated

Comment thread apps/sim/lib/logs/execution/logger.ts Outdated

fix(execution): scope the snapshot FK retry, keep a suspended identit…

1287244

…y's access read out of the run, tidy tests

vercel Bot temporarily deployed to Preview September 29, 2026 21:40 Inactive

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

improvement(execution): encapsulate early admission reads, plain snap…

9735252

…shot identity, explicit suspension paths

vercel Bot temporarily deployed to Preview September 29, 2026 21:58 Inactive

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread apps/sim/lib/environment/utils.ts

Comment thread apps/sim/lib/logs/execution/snapshot/service.ts

improvement(environment): reuse the actor's resolved access when with…

ee42ccf

…holding a suspended identity

vercel Bot temporarily deployed to Preview September 29, 2026 22:12 Inactive

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

waleedlatif1 merged commit d3f2830 into staging Sep 29, 2026
33 checks passed

waleedlatif1 deleted the perf/execution-preprocessing branch September 29, 2026 22:31

waleedlatif1 mentioned this pull request Sep 30, 2026

v0.9.7: embeddings cleanup, search expansion, navigation and execution speedup #8439

Merged

Conversation

waleedlatif1 commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Results

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 29, 2026 •

edited

Loading

vercel Bot commented Sep 29, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 29, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading