Skip to content

fix(desktop): return source connections to the app #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Sep 30, 2026
+1,875 −118
Merged

fix(desktop): return source connections to the app #8486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7898ac
fix(desktop): return source connections to the app
waleedlatif1 Sep 30, 2026
bd0579f
fix(desktop): preserve enrollment mode and completion state
waleedlatif1 Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/desktop-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ on:
- 'apps/sim/app/layout.tsx'
- 'apps/sim/hooks/use-desktop-update-state.ts'
- 'apps/sim/lib/desktop/**'
- 'apps/sim/app/desktop/connect/**'
- 'apps/sim/app/credential-groups/**'
- 'apps/sim/hooks/queries/slack-search.ts'
Comment thread
waleedlatif1 marked this conversation as resolved.
- 'apps/sim/hooks/use-github-installation-setup.ts'
- 'apps/sim/app/o/**/integrations/indexed/use-member-enrollment.ts'
- 'apps/sim/lib/api/contracts/desktop-source-connect.ts'
- 'apps/sim/scripts/fixtures/desktop-source-connect.tsx'
- 'apps/sim/app/workspace/**/browser-session/**'
- 'apps/sim/app/_styles/**'
- 'apps/sim/lib/postcss/**'
Expand Down Expand Up @@ -61,6 +68,10 @@ jobs:
working-directory: apps/desktop
run: bun run build

- name: Install system-browser fixture
working-directory: apps/desktop
run: bunx playwright install chromium

- name: Run Playwright _electron smoke suite
working-directory: apps/desktop
run: bunx playwright test
Expand Down Expand Up @@ -98,6 +109,10 @@ jobs:
working-directory: apps/desktop
run: bun run build

- name: Install system-browser fixture
working-directory: apps/desktop
run: bunx playwright install chromium

- name: Run Playwright _electron smoke suite
working-directory: apps/desktop
run: bunx playwright test
Expand Down
2 changes: 2 additions & 0 deletions apps/desktop/e2e/fixtures/browser-buffer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/** Matches Next's browser Buffer polyfill when bundling application code with esbuild. */
export { Buffer } from 'buffer'
Loading
Loading