You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep account connection and reconnect on the originating Integrations page, with automatic refresh and a same-tab fallback when popups are unavailable.
Complete managed MCP authorization directly while preserving invitation submission and existing Search flows.
Correlate browser and desktop completion per attempt, prevent overlapping starts, and preserve the selected OAuth credential during reconnect.
Type of Change
Bug fix
Testing
197 focused and neighboring tests; five new callback/state regressions demonstrated failing before the fix.
Browser/Electron E2E: 13 lifecycle checks covering completion, cancellation, reconnect, preserved page state, popup fallback, separate sessions, and invitation compatibility. JSON report and screenshot generated; CI uploads failure artifacts.
App and desktop type checks, lint, 52 audits, block registry validation, and docs manifest check.
Checklist
Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
[Medium risk] Adds account connection completion flow for integrations.
The PR appears safe to merge; no outstanding findings remain.
Summary
The PR completes managed account authorization through the originating Integrations page, using correlated popup or desktop handoffs and a same-tab fallback. Since the previous review, it adds a shared guard against overlapping connection attempts and extends the desktop fixture to exercise MCP accounts.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Integrations Connect or Reconnect] --> B[Start correlated authorization]
B --> C{Desktop or web?}
C -->|Desktop| D[Native browser handoff]
C -->|Web popup| E[Provider popup]
C -->|Popup unavailable| F[Same-tab authorization]
D --> G[Completion page]
E --> G
F --> G
G --> H[Refresh accounts or return to Integrations]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist
test-auditauthoring gate)