Skip to content

fix(dashboards): menu order, org-chat entitlement, mention ids, contract bounds - #8495

Merged
waleedlatif1 merged 4 commits into
stagingfrom
fix/dashboard-mention
Oct 1, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
fix/dashboard-mention

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Order dashboards between chats and tables in every resource menu (@ mention, + attach, resource-tab +), instead of first
  • Drop the rule that resource menus mirror the sidebar (.claude/rules/sim-list-ordering.md, its Cursor copy, CLAUDE.md); RESOURCE_MENU_ORDER is now its own product order
  • Fix the dashboard findings cubic raised on v0.9.8: search cleanup recovery, new search providers, billing and chat reliability #8494:
    • Org chats no longer get dashboard commands. Entitlement evaluators now declare the scopes (workspace / organization) they exist in, and an undeclared scope is never granted, so dashboards (workspace-only) can't leak into an org chat with no workspace to run against. An owner carrying both ids throws.
    • Dashboard mentions keep their id. The optimistic-send copy in use-chat.ts and the reload copy in display-message.ts both dropped dashboardId. Persist, read and display now share one copyPersistedMessageContext, so a new id field gets added in one place.
    • Chart readout label is announced — role='group' on the readout wrapper
    • Read contract reuses the bounded schemas — dashboardContentSchema / dashboardRevisionSchema (the write path already enforces both)
    • Revision integration test no longer depends on the first test — it inserts its own workspace row

Type of Change

  • Bug fix

Testing

  • New tests: org chat gets no dashboards entitlement (payload.test.ts); reopened dashboard mention keeps dashboardId (display-message.test.ts)
  • bun run test on payload, display-message, persisted-message, messages-store, use-chat and lib/dashboards (138 pass)
  • repository.integration.ts against local Postgres, in full and the revision test alone
  • bun run type-check, bun run lint, bun run check:audits (52 audits pass)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01HqEUjQv32TzpsJASPmbdnM

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 1, 2026 1:58am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 2/5

[Medium risk] Reorders dashboard in resource menus and adds dashboard context support.

The PR is not yet safe to merge because closing an authorization popup strands account connection, and the server can report conversions without current marketing consent.

Summary

The PR adjusts resource-menu ordering and dashboard/chat contracts, and adds account-connection handoff, workflow recovery, and conversion-tracking changes.

  • Account authorization now uses a completion channel to return to the initiating Integrations page.
  • Workflow execution and orphan recovery gain server-side settlement and lease checks.
  • Signup adds consent-gated client tracking and a server conversion postback.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Integrations connection] --> B[Authorization popup]
  B --> C[OAuth callback]
  C --> D[Completion page]
  D --> E[Broadcast to initiating tab]
  E --> F[Refresh accounts]
Loading

Reviews (3) · Last reviewed commit: "fix(dashboards): scope entitlements, kee..."

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks TheodoreSpeaks changed the title fix(mothership): order dashboards between chats and tables in resource menus fix(dashboards): menu order, org-chat entitlement, mention ids, contract bounds Oct 1, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

…ion-resolve

# Conflicts:
#	apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts
#	apps/sim/components/charts/time-series-chart.tsx
#	apps/sim/lib/dashboards/repository.integration.ts
#	apps/sim/lib/mothership/chat/display-message.ts
@waleedlatif1
waleedlatif1 merged commit bd46dfb into staging Oct 1, 2026
20 of 21 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/dashboard-mention branch October 1, 2026 01:56

This branch was successfully deployed

1 active deployment
Preview — c852a69d Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants