Skip to content

fix(integrations): close connection recovery edge cases - #8497

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/source-connect-edge-cases
Oct 1, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/source-connect-edge-cases

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Cancel pending Slack web authorization requests and preserve active desktop Search attempts until completion, cancellation, or expiry.
  • Keep managed Slack session-expiry recovery consistent across browser and desktop, and bound desktop ticket parsing to 64 KiB while retaining the 32 KiB ticket limit.
  • Add regression coverage for all four cases and run desktop E2E when either Search connection hook changes.

Type of Change

  • Bug fix

Testing

  • All four regressions demonstrated their intended failure before the corresponding fix.
  • 50 focused tests and 15 browser/Electron lifecycle checks passed; the latter use real hooks, native IPC, loopback handoff, and simulated provider HTTP.
  • App and desktop type checks, lint, 52 audits, generators, block registry checks, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 1:35am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Fixes connection recovery in integration OAuth flows.

The PR appears safe to merge; no outstanding or new actionable finding remains.

Summary

This PR tightens Slack and desktop Search connection recovery and adds regression coverage.

  • Propagates cancellation to Slack web authorization requests and prevents a pending desktop Search attempt from being overwritten.
  • Aligns managed Slack sign-in recovery, bounds desktop request parsing, and expands desktop E2E triggers.
  • Revises E2E assertions to check connection outcomes rather than rendered status text.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Connect] --> B{Desktop Search attempt pending?}
  B -->|Yes| C[Preserve existing receipt]
  B -->|No| D[Start authorization]
  D --> E{Outcome}
  E -->|Cancel| F[Abort or mark failed]
  E -->|Complete| G[Inventory confirms credential]
  G --> H[Store connected receipt]
Loading

Reviews (2) · Last reviewed commit: "fix(integrations): verify persisted conn..."

Comment thread apps/desktop/e2e/source-connect.spec.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 51f793b into staging Oct 1, 2026
26 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/source-connect-edge-cases branch October 1, 2026 01:42

This branch was previously deployed

1 inactive deployment
Preview — f6731c8a Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant