Skip to content

fix(desktop): install browser before release smoke tests - #8504

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/desktop-release-browser-fixture
Oct 1, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/desktop-release-browser-fixture

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Install Playwright Chromium before the desktop release smoke suite. Source-connection E2E launches a separate browser, so a fresh release runner needs the same browser setup as the dedicated desktop E2E workflow.

Type of Change

  • Bug fix

Testing

  • Reproduced the missing-executable failure with an empty browser cache.
  • Ran the added installation command against that cache, then passed all 15 source-connection browser/Electron lifecycle checks.
  • Actionlint, lint, all 52 audits, generators, block registry checks, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing E2E coverage passing (workflow-only change)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 1, 2026 1:59am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds a setup step to the desktop release workflow.

The PR appears safe to merge.

Summary

The release workflow now installs Playwright Chromium before running desktop smoke tests.

  • The installation supplies the separate browser required by the source-connection E2E test.
  • Its placement matches the dedicated desktop E2E workflow.

Reviews (1) · Last reviewed commit: "fix(desktop): install browser before rel..."

@waleedlatif1
waleedlatif1 merged commit fa32bc1 into staging Oct 1, 2026
26 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/desktop-release-browser-fixture branch October 1, 2026 02:00

This branch was successfully deployed

1 active deployment
Preview — cd527c0d Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant