Skip to content

fix(chat): keep mention searches open and align resource menus - #8507

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/composer-mentions
Oct 1, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/composer-mentions

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep mention searches open across spaces and punctuation, and preserve explicit dismissal while typing.
  • Include organization workspaces in both mention and resource-menu search, without prematurely attaching integration-name prefixes.
  • Use a stable, responsive 360px width through nested resource folders, with bounded workspace labels.
  • Preserve the highlighted resource as inventories load and reopen search when replacing a dismissed trigger.

Type of Change

  • Bug fix

Testing

  • 40 tests passed across the prompt editor, organization composer, organization resource inventory, and resource folder tree.
  • Regression tests reproduced space dismissal, Escape reopening, unintended integration attachments, and selection/programmatic replacement failures before their fixes.
  • Passed app type-check, repository lint, all 52 audits, block-registry validation, and docs-manifest check.
  • Browser fixture verified both composer scopes, workspace selection, multiword and punctuated searches, Escape, Enter/Tab selection, and a 375px viewport. Before/after screenshots captured with sample data. Also verified deferred loading preserves the highlighted attachment, nested folder widths, selection without reopening, and searching beyond the workspace preview limit.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 8:03am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adjusts mention search behavior and dropdown menu styling.

The PR appears safe to merge; the previous findings are resolved and no new actionable issue was established.

Summary

This PR keeps mention searches usable across spaces and punctuation, adds organization workspaces to resource search, and aligns submenu widths.

  • Subsequent changes preserve dismissal during selection and limit only the unfiltered workspace preview.
  • All three previous findings are resolved; no new actionable issue was established.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Type @ query] --> B[Search workspaces and resources]
  B --> C[Select candidate]
  B --> D[Dismiss menu]
  D --> E[Keep dismissal while selecting or typing]
  E --> F[Replace trigger or start a new one]
  F --> B
Loading

Reviews (3) · Last reviewed commit: "fix(chat): reset replaced queries and bo..."

@greptile-apps

This comment has been minimized.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Addressed the outside-diff dismissal finding: selecting a range that includes the dismissed @ now releases that dismissal, so replacing it at the same offset opens a fresh search. The regression failed before the change in both composer scopes and now passes; the browser flow also passes. Leaving a query with the caret intentionally resets dismissal, so returning to that query after editing elsewhere can open suggestions again. Continuing to type in the dismissed query keeps it closed.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit d6f38a0 into staging Oct 1, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/composer-mentions branch October 1, 2026 08:07

This branch was previously deployed

1 inactive deployment
Preview — bee13812 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant